Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move module to ec2 dir, update docs #176

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Move module to ec2 dir, update docs #176

merged 1 commit into from
Feb 10, 2025

Conversation

dkeightley
Copy link
Contributor

  • Update all docs
  • Move aws module to ec2 subdirectory in preparation for EKS and VPC modules

@glovecchi0
Copy link

Good idea, Derek!
I did the same on Google and on these forms during the review (the PRs that I then closed).

glovecchi0
glovecchi0 approved these changes Feb 10, 2025
View reviewed changes
Copy link

@glovecchi0 glovecchi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glovecchi0
Copy link

PS: If needed, for EKS, you can look here.

@dkeightley dkeightley merged commit 56e49e1 into main Feb 10, 2025
3 checks passed
@dkeightley dkeightley deleted the move-aws-ec2 branch February 10, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glovecchi0 glovecchi0 glovecchi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkeightley @glovecchi0