Added CNI Addressing options and vappProperty cluster variables #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pknomad
commented
Jan 7, 2025
pknomad
commented
- Added cluster-cidr and service-cidr into cluster.yaml to set CNI address
- Added vappProperty settings
- Added pool and network back into vsphere values (commented out)
Updated cluster.yaml to include settings for cluster and service CIDR for pod communication via CNI.
Update values.yaml to ingest cluster and service cidr settings into cluster.yaml. The default values are using rancher defaults: https://ranchermanager.docs.rancher.com/reference-guides/cluster-configuration/rancher-server-configuration/gke-cluster-configuration#container-address-range
Re-added network and pool settings for vsphere nodes and added vapp settings (vappIpallocationpolicy, vappIpprotocol, vappTransport, and vappProperty). vappProperty settings in comments sets ip, gateway, dns if all 3 options are needed
|
Hey @pknomad… Thanks for putting this together and pinging us in Issue #46! I saw this last over the weekend, but didn’t get a chance to look at it. Could you update your PR with the below minor updates/changes? In the cluster-cidr: 10.42.0.0/16 # https://docs.rke2.io/networking/basic_network_options
service-cidr: 10.43.0.0/16 # https://docs.rke2.io/networking/basic_network_options |
Updated cluster-cidr and service-cidr to include rancher documentation link
|
Hey @zackbradys, Done! Let me know if any other revisions are needed. I'm also happy to validate IPv6 setting for VAPP property options when it's fully supported by Rancher. Thanks for the review! Cheers, |
|
Hey @pknomad... I updated the rest of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.