Adding DNS tests to overlay test as an optional check #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing capabilities - Added support for DNS checks via '--dns-check' argument - Improved output messages for better clarity on test results - Consolidated pod information retrieval in one command for efficiency - Enhanced error handling for DNS resolution tests
dkeightley
requested changes
Jan 29, 2025
|
|
||
| echo "=> Start network overlay, DNS, and API test" | ||
|
|
||
| kubectl get pods -l name=overlaytest -o jsonpath='{range .items[*]}{@.metadata.name}{" "}{@.spec.nodeName}{" "}{@.status.podIP}{"\n"}{end}' | sort -k2 | |
There was a problem hiding this comment.
Should the kubectl commands add -n default? For example if using admin-tools.yaml (which includes the SA to run these commands from a pod) it’ll create and deploy into it’s own namespace and kubectl won’t select any overlaytest pods
| while read tip thost | ||
| do | ||
| if [[ ! $shost == $thost ]]; then | ||
| kubectl --request-timeout='10s' exec $spod -c overlaytest -- /bin/sh -c "ping -c2 $tip > /dev/null 2>&1" |
There was a problem hiding this comment.
I found the --request-timeout='10s' flag seems to stop kubectl from using the SA token to auth, and it errors like kubectl doesn’t have a kubeconfig. Strange, only repro’s when running in a pod. If you also find this, we may need to run without the flag?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor overlaytest.sh to enhance network overlay test to add DNS testing capabilities