Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aarch64 native builds to CI #4562

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add aarch64 native builds to CI #4562

wants to merge 3 commits into from

Conversation

randombit
Copy link
Owner

No description provided.

@randombit randombit force-pushed the jack/add-native-aarch64-ci branch from b574b6e to a04d7ac Compare January 17, 2025 02:34
@coveralls
Copy link

coveralls commented Jan 17, 2025 •
edited
Loading

Coverage Status

coverage: 91.211% (+0.002%) from 91.209%
when pulling 4e630a8 on jack/add-native-aarch64-ci
into 6a97b80 on master.

@randombit randombit force-pushed the jack/add-native-aarch64-ci branch from a04d7ac to af8c4e4 Compare January 17, 2025 10:18
@randombit
Copy link
Owner Author

Valgrind builds are pointing to uninitialized memory in TLS in GCC, and a const-time issue in Classic McEliece. I can't replicate either issue with GCC 14/Clang 19 on a Neoverse N1 machine running Debian.

@randombit
Copy link
Owner Author

cc @reneme @FAlbertDev regarding Classic McEliece

@reneme
Copy link
Collaborator

reneme commented Jan 17, 2025

@randombit caution! I'll push some commits into this branch to enable debug symbols for valgrind and work on the matrix.

@reneme reneme force-pushed the jack/add-native-aarch64-ci branch from 5a0ac57 to 143c220 Compare January 17, 2025 14:55
@reneme reneme force-pushed the jack/add-native-aarch64-ci branch from 143c220 to 4e630a8 Compare January 17, 2025 14:57
@reneme
Copy link
Collaborator

reneme commented Jan 17, 2025

Valgrind builds are pointing to uninitialized memory in TLS in GCC, and a const-time issue in Classic McEliece. I can't replicate either issue with GCC 14/Clang 19 on a Neoverse N1 machine running Debian.

I enabled --with-debug-info for the valgrind targets. Hopefully, this build will provide some extra info: https://github.com/randombit/botan/actions/runs/12831471225/job/35782005838?pr=4562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneme reneme reneme left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randombit @coveralls @reneme