Fix tests & rows closing

raphaelvigee · Nov 21, 2020 · 8e9d19c · 8e9d19c
1 parent 3b73e8c
commit 8e9d19c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/driver/gorm/map.go b/driver/gorm/map.go
@@ -10,6 +10,7 @@ func TakeMap(tx *gorm.DB) (map[string]interface{}, error) {
 	if err != nil {
 		return nil, err
 	}
+	defer rows.Close()
 
 	if !rows.Next() {
 		return nil, nil
@@ -28,6 +29,7 @@ func FindMap(tx *gorm.DB) ([]map[string]interface{}, error) {
 	if err != nil {
 		return nil, err
 	}
+	defer rows.Close()
 
 	return rowsMap(rows)
 }

diff --git a/driver/gorm/paginator_test.go b/driver/gorm/paginator_test.go
@@ -27,6 +27,12 @@ func SetupDb(models ...interface{}) (*gormdb.DB, context.CancelFunc) {
 		panic(fmt.Sprintf("Failed to connect to db: %v", err))
 	}
 
+	sqlDB, err := db.DB()
+	if err != nil {
+		panic(fmt.Sprintf("Failed to get db: %v", err))
+	}
+	sqlDB.SetMaxOpenConns(1)
+
 	db.AutoMigrate(models...)
 
 	ctx, cancel := context.WithCancel(context.Background())