Make datastore to_h sane #19890
Merged
Make datastore to_h sane #19890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
approved these changes
Feb 18, 2025
sjanusz-r7
force-pushed
the
make-datastore-to_h-sane
branch
from
339319d to
ecba7db
Compare
|
We should verify that these workflows work as expected still: #19002 |
adfoster-r7
approved these changes
Feb 18, 2025
Release NotesFixes a bug that caused persisted jobs to be stored as empty strings instead of nil values, and fixes a bug in Metasploit Pro's replay module capabilities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the metasploit_data_models gem version.
It also makes the datastore
to_hmethod more sane, and removes the coalescing of values to a string, making this method more aligned with a programmer's expectations.Requires the serialization changes from here:rapid7/metasploit_data_models#207
Verification
msfconsolePersistence Workflow
Persistence works as expected, with the steps taken from #19002
