Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AndroidManifest.xml #734

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update AndroidManifest.xml #734

wants to merge 1 commit into from

Conversation

k41ed
Copy link

@k41ed k41ed commented Nov 12, 2024

Update AndroidManifest for compatibility with Android 11-14

  • Updated targetSdkVersion to 33 for modern Android support.
  • Added android:exported attribute to MainActivity and components with intent filters as required by Android 12+.
  • Limited certain permissions (e.g., SMS, external storage) with maxSdkVersion for Android 11+.
  • Added tools:ignore="ProtectedPermissions" for WRITE_SETTINGS permission to suppress Lint warnings.
  • Declared optional hardware features to improve device compatibility.
  • Enabled legacy storage with requestLegacyExternalStorage for backward compatibility.

Update AndroidManifest for compatibility with Android 11-14

- Updated targetSdkVersion to 33 for modern Android support.
- Added android:exported attribute to MainActivity and components with intent filters as required by Android 12+.
- Limited certain permissions (e.g., SMS, external storage) with maxSdkVersion for Android 11+.
- Added tools:ignore="ProtectedPermissions" for WRITE_SETTINGS permission to suppress Lint warnings.
- Declared optional hardware features to improve device compatibility.
- Enabled legacy storage with requestLegacyExternalStorage for backward compatibility.
@k41ed
Copy link
Author

k41ed commented Nov 12, 2024

Awaiting approval on this workflow so I can proceed with further modifications in some files. Thank you!

@h00die
Copy link
Contributor

h00die commented Nov 12, 2024

@k41ed, please have patience. There's likely about 50 people in the entire world who have permissions to merge this request. Of those, 10-20 likely aren't around or active any more. Of the remaining, not everyone is familiar with Android architecture, and the changes you've proposed. Of those remaining who work for rapid7, they'll also have to prioritize this request versus the others. I'd encourage you to give it a week or two, then ping again. Also, if it makes sense to combine this PR with some other changes, you may as well since it may be a while.

@timwr if you're bored and still around, this may speak to you!

@k41ed
Copy link
Author

k41ed commented Nov 13, 2024 via email

@k41ed
Copy link
Author

k41ed commented Nov 13, 2024

I’ll work on fixing this as soon as possible

@h00die
Copy link
Contributor

h00die commented Nov 13, 2024

Are there any instructions on how to test this change? My assumption would be to create a gem, then go over to the metasploit side, install the gem, then create an apk via msfvenom. Then install it to a newer android phone, and you'll no longer get the warnings that the apk was designed for an older version of android. Do you have any notes from how you tested it that differ from this?

@dledda-r7 dledda-r7 self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants