InstantSearch migration #706
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jade-GG
reviewed
Jan 16, 2025
indykoning
reviewed
Jan 23, 2025
Comment on lines
25
to
28
| TODO: Double check this, the data updates, | ||
| but the component doesn't. Tried to | ||
| make everything working recursive | ||
| plus keep it renderless. |
There was a problem hiding this comment.
This usually is solved by adding a :key that will change depending on the data so the element is forcibly rerendered: https://vuejs.org/api/built-in-special-attributes#key
Implement autocomplete using instantsearch-vue
[Instantsearch] Scout indexing products & categories
…pidez/core into feature/instantsearch-routing
…m/rapidez/core into feature/instantsearch-search-page
…ecursion Fix the recursion of the recursion component
Co-authored-by: Roy Duineveld <[email protected]>
…pidez/core into feature/instantsearch-routing
[Instantsearch] Routing
[Instantsearch] Custom search queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactiveSearch is within Rapidez from day 1, but the current status is unclear and there isn't much activity on Github. We choose this as Magento requires Elasticsearch / OpenSearch, so no additional requirements.
In the past we've worked with InstantSearch from Algolia which supports more search engines which is a good alternative and it integrates with multiple search engines:
With this migration; we could migrate to Laravel Scout so we can get rid of our custom indexer, use a first party Laravel package, get batch imports out-of-the-box and more advantages. Laravel Scout also supports multiple search engines; Algolia, Meilisearch and Typesense out-of-the-box. There are some custom drivers for Elasticsearch:
This current proof of concept is using Meilisearch, but I'm not yet convinced as locally (on a M1) I can't get it faster than 300ms where Elasticsearch responds within 50ms. Not sure yet how easy it is to switch between engines; maybe it will be configurable with Elasticsearch as default; so you can use the same infrastructure.
To be continued 🚀
Oh and yes; we're also going to migrate to Vue 3; but after this within a separated PR.
Update: Switched to Elasticsearch using Searchkit. Performance is back to what we're used to and within the core (but also within some projects) custom query DSL is used; so sticking to Elasticsearch is preferred.