Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Remove upper bound pin on numpy #14166

Closed
vyasr opened this issue Sep 21, 2023 · 1 comment
Closed

[FEA] Remove upper bound pin on numpy #14166

vyasr opened this issue Sep 21, 2023 · 1 comment
Labels
0 - Backlog In queue waiting for assignment feature request New feature or request Python Affects Python cuDF API.

Comments

@vyasr
Copy link
Contributor

vyasr commented Sep 21, 2023

Is your feature request related to a problem? Please describe.
#14156 introduces an upper bound pinning to numpy because version 1.25 deprecates some core functionality that we use, namely np.find_common_type.

Describe the solution you'd like
We should refactor our internals to remove usage of this deprecated function, then remove the pin.

Describe alternatives you've considered
None

Additional context
pandas also uses this function internally and therefore will emit warnings when used with a newer numpy. This is fixed in pandas 2.0, but the fixes are not being backported, so we can't fully resolve this issue until cudf also switches to supporting pandas 2.x.

@vyasr vyasr added feature request New feature or request Needs Triage Need team to review and classify labels Sep 21, 2023
@GregoryKimball GregoryKimball added 0 - Backlog In queue waiting for assignment Python Affects Python cuDF API. and removed Needs Triage Need team to review and classify labels Nov 9, 2023
@vyasr
Copy link
Contributor Author

vyasr commented May 15, 2024

This was removed a while ago, we now support newer numpy versions.

@vyasr vyasr closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog In queue waiting for assignment feature request New feature or request Python Affects Python cuDF API.
Projects
None yet
Development

No branches or pull requests

2 participants