Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin to numpy<1.25 and numba<0.58 to avoid errors and deprecation warnings-as-errors. #14156

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Pin to numpy<1.25 and numba<0.58 to avoid errors and deprecation warnings-as-errors. #14156

merged 3 commits into from
Sep 21, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Sep 21, 2023 •
edited
Loading

Description

Closes #14155.

Related: #14160.

(Will newer numpy support be backported to pandas 1.x? edit: no, see below)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested review from a team as code owners September 21, 2023 17:02
@bdice bdice requested review from wence- and shwina September 21, 2023 17:02
@github-actions github-actions bot added Python Affects Python cuDF API. conda labels Sep 21, 2023
@mroeschke
Copy link
Contributor

Sorry, np.find_common_type usage was only addressed in 2.0.x and won't be backported to 1.x: pandas-dev/pandas#53343

@bdice bdice marked this pull request as draft September 21, 2023 17:09
@bdice bdice changed the title Pin to numpy <1.26. Pin to numpy <1.25 to avoid deprecation warnings-as-errors. Sep 21, 2023
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Sep 21, 2023
@bdice bdice self-assigned this Sep 21, 2023
@bdice bdice marked this pull request as ready for review September 21, 2023 18:30
@bdice bdice requested review from vyasr and removed request for wence- September 21, 2023 18:30
@bdice bdice changed the title Pin to numpy <1.25 to avoid deprecation warnings-as-errors. Pin to numpy <1.25 and numba<0.58 to avoid errors and deprecation warnings-as-errors. Sep 21, 2023
@bdice bdice changed the title Pin to numpy <1.25 and numba<0.58 to avoid errors and deprecation warnings-as-errors. Pin to numpy<1.25 and numba<0.58 to avoid errors and deprecation warnings-as-errors. Sep 21, 2023
@vyasr
Copy link
Contributor

vyasr commented Sep 21, 2023

@bdice do you want to create another issue like #14160 for the numpy warnings (which we will also need to fix)? Or repurpose #14155 and leave it open after this PR merges, either is fine with me as long as we're tracking the work.

@bdice
Copy link
Contributor Author

bdice commented Sep 21, 2023 •
edited
Loading

@bdice do you want to create another issue like #14160 for the numpy warnings (which we will also need to fix)? Or repurpose #14155 and leave it open after this PR merges, either is fine with me as long as we're tracking the work.

I don't have a strong opinion about how we resolve this -- maybe a new issue is best. But for now, I don't see a lot of benefit to fixing these warnings until we are ready to migrate cudf to pandas 2. Then it'll be easier to tell what usage is deprecated in cudf and not just what's deprecated in the pandas internals. If you want to figure that out, I'd appreciate help with filing a second issue (my plate is very full for today already).

@vyasr
Copy link
Contributor

vyasr commented Sep 21, 2023

But for now, I don't see a lot of benefit to fixing these warnings until we are ready to migrate cudf to pandas 2. Then it'll be easier to tell what usage is deprecated in cudf and not just what's deprecated in the pandas internals. If you want to figure that out, I'd appreciate help with filing a second issue (my plate is very full for today already).

I agree, I don't think we should work on this immediately. I just want an issue tracking this so that we don't forget to move the pin when we bump our pandas version. I'll open a stub issue for tracking that we can fill out with more info later.

@vyasr vyasr mentioned this pull request Sep 21, 2023
Closed
@vyasr
Copy link
Contributor

vyasr commented Sep 21, 2023

Opened #14166

@vyasr
Copy link
Contributor

vyasr commented Sep 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit f0ba859 into rapidsai:branch-23.10 Sep 21, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@raydouglass raydouglass raydouglass approved these changes

@vyasr vyasr vyasr approved these changes

@quasiben quasiben quasiben approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@bdice bdice

Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Pin wheel builds to numpy <1.25
6 participants
@bdice @mroeschke @vyasr @quasiben @raydouglass @galipremsagar