-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various issues in Index.intersection
#14054
Fix various issues in Index.intersection
#14054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some refactoring ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@galipremsagar you mentioned this was blocking some other work -- if you'd like to move it forward and then follow up on the refactoring steps that I mentioned in comments, go ahead. I don't think those refactorings are crucial, just nice-to-have. Approving.
Addressed the refactor reviews in this PR. Thanks @bdice ! |
Merging this, @bdice if you think there is more to be addressed let me know I'll tackle it in a follow-up PR. |
/merge |
Description
This PR fixes multiple issues with
Index.intersection
:Index.intersection
throwing error on empty inputs #14020intersection
implementation and fixRangeIndex.intersection
by having a separate implementation for it.Checklist