Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mr from test fixtures #14075

Closed
wants to merge 3 commits into from

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Sep 11, 2023

Description

This is a follow-up to #14057. The PR was split in two because in that PR this particular change led to an unexpected and very specific test failure (see #14057 (comment)). If this PR reproduces that issue we will need to debug more closely on the appropriate hardware.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team tests Unit testing for project libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 11, 2023
@vyasr vyasr self-assigned this Sep 11, 2023
@vyasr vyasr requested a review from a team as a code owner September 11, 2023 17:11
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me!

@karthikeyann
Copy link
Contributor

Same tests failed as https://github.com/rapidsai/cudf/actions/runs/6126279847/job/16630671974?pr=14057
doesn't seem random, but can't find a pattern either.
No errors while running it with valgrind, compute-sanitizer (memcheck, racecheck, initcheck, synccheck)

[  FAILED  ] 5 tests, listed below:
[  FAILED  ] RoundRobinTest/4.RoundRobinNPartitionsDivideNRows, where TypeParam = unsigned char
[  FAILED  ] RoundRobinTest/7.RoundRobinNPartitionsDivideNRows, where TypeParam = unsigned long
[  FAILED  ] RoundRobinTest/10.RoundRobinNPartitionsDivideNRows, where TypeParam = double
[  FAILED  ] RoundRobinTest/15.RoundRobinNPartitionsDivideNRows, where TypeParam = cuda::std::__4::chrono::time_point<cuda::std::__4::chrono::system_clock,cuda::std::__4::chrono::duration<long,cuda::std::__4::ratio<1l,1000000000l> > >
[  FAILED  ] RoundRobinTest/23.RoundRobinNPartitionsDivideNRows, where TypeParam = numeric::fixed_point<__int128,(numeric::Radix)10>

 5 FAILED TESTS

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 12, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the CMake CMake build issue label Sep 12, 2023
@github-actions github-actions bot removed the CMake CMake build issue label Sep 12, 2023
@karthikeyann
Copy link
Contributor

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Sep 28, 2023

@robertmaynard and I have both spent some time trying to investigate the issues here. We were unable to reproduce on at least one other arm node, and Robert said he was not able to reproduce this using CUDA 12. Since the issue appears to be very specific and compiler-related, I'm going to close this PR for now. The plan will be to reopen this once we drop CUDA 11 support since the issue appears to be specific to CUDA 11.

@vyasr
Copy link
Contributor Author

vyasr commented Sep 28, 2023

Tracking in #14236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants