Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix renaming Series and Index #14080

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Fix renaming Series and Index #14080

merged 2 commits into from
Sep 12, 2023

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Sep 11, 2023 •
edited
Loading

Fixes: #14076

Description

This PR resolves renaming Series and Index by assigning no_default to internal API default parameters.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Sep 11, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner September 11, 2023 23:25
@galipremsagar galipremsagar self-assigned this Sep 11, 2023
bdice
bdice approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, and should resolve the linked issue. Is no_default a pandas 2.0 thing though? Or is no_default how pandas itself handles this case in the 1.x line?

@galipremsagar
Copy link
Contributor Author

Changes look fine, and should resolve the linked issue. Is no_default a pandas 2.0 thing though? Or is no_default how pandas itself handles this case in the 1.x line?

Pandas doesn't have a no_default for these APIs nor did we change default parameters for the public APIs. Only our private APIs needed this fix and issue gets resolved.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Sep 11, 2023
mroeschke
mroeschke approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

(In pandas, I think None has always been the default so I think this matches cudf)

@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c3bf705 into rapidsai:branch-23.10 Sep 12, 2023
54 checks passed
etseidl pushed a commit to etseidl/cudf that referenced this pull request Sep 12, 2023
@galipremsagar @etseidl
Fix renaming Series and Index (rapidsai#14080)
4b7e80c 
This PR resolves renaming `Series` and `Index` by assigning `no_default` to internal API default parameters.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Matthew Roeschke (https://github.com/mroeschke)

URL: rapidsai#14080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@bdice bdice bdice approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Series.rename(None) does not rename existing name to None
3 participants
@galipremsagar @bdice @mroeschke