Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor hash_reduce_by_row #14095

Merged
merged 19 commits into from
Sep 13, 2023
Merged

Refactor hash_reduce_by_row #14095

merged 19 commits into from
Sep 13, 2023

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Sep 12, 2023 •
edited
Loading

This PR extracts hash_reduce_by_row function from distinct_reduce.* files. Previously, that function was designed specifically to work with distinct in stream compaction with size_type output. Now, it becomes more generic and can support more generic reduction operations and various output types.

No new functionality was added.

The changes in this work pave the way for implementing histogram/merge histogram aggregations, which also rely on hash-base reduction.

@ttnghia ttnghia added 3 - Ready for Review Ready for review by team libcudf blocker libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Sep 12, 2023
@ttnghia ttnghia self-assigned this Sep 12, 2023
@ttnghia ttnghia requested a review from a team as a code owner September 12, 2023 18:18
@ttnghia ttnghia requested review from vyasr and vuule September 12, 2023 18:18
@ttnghia ttnghia added the feature request New feature or request label Sep 12, 2023
karthikeyann
karthikeyann approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ttnghia ttnghia requested a review from a team as a code owner September 12, 2023 19:46
@github-actions github-actions bot added the CMake CMake build issue label Sep 12, 2023
PointKernel
PointKernel approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Thanks for the iteration and your effort in addressing reviews.

@ttnghia
Copy link
Contributor Author

ttnghia commented Sep 13, 2023

/merge

bdice
bdice approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving CMake changes.

@rapids-bot rapids-bot bot merged commit edfef80 into rapidsai:branch-23.10 Sep 13, 2023
54 checks passed
@ttnghia ttnghia deleted the refactor_hash_reduce branch September 14, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ttnghia @bdice @karthikeyann @PointKernel