Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop kwargs from Series.count #14106

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Drop kwargs from Series.count #14106

merged 1 commit into from
Sep 18, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #14089
This PR drops kwargs from Series.count method signature.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Sep 13, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner September 13, 2023 18:19
@galipremsagar galipremsagar self-assigned this Sep 13, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner September 13, 2023 18:19
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Sep 13, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5935ef3 into rapidsai:branch-23.10 Sep 18, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@quasiben quasiben quasiben approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Series.count shouldn't be allowing kwargs
3 participants
@galipremsagar @quasiben @mroeschke