Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataFrame.values with no columns but index #14134

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Fix DataFrame.values with no columns but index #14134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4478d1
Fix DataFrame.values with no columns but index
mroeschke Sep 19, 2023
f0eb340
Change to compare against pandas
mroeschke Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/cudf/cudf/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ def get_column_values_na(col):
ncol = self._num_columns
if ncol == 0:
return make_empty_matrix(
shape=(0, 0), dtype=np.dtype("float64"), order="F"
shape=(len(self), ncol), dtype=np.dtype("float64"), order="F"
)

if dtype is None:
Expand Down
6 changes: 6 additions & 0 deletions python/cudf/cudf/tests/test_dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10374,3 +10374,9 @@ def test_dataframe_init_from_nested_dict():
pdf = pd.DataFrame(regular_dict)
gdf = cudf.DataFrame(regular_dict)
assert_eq(pdf, gdf)


def test_data_frame_values_no_cols_but_index():
result = cudf.DataFrame(index=range(5)).values
expected = pd.DataFrame(index=range(5)).values
assert_eq(result, expected)