Raise ValueError if DataFrame column length does not match data

[mroeschke]

Description

closes #14131

Checklist

• I am familiar with the Contributing Guidelines.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.

[davidwendt]

Is the PR title missing a not ?

[mroeschke]

Is the PR title missing a not ?

Yes, thanks!

[mroeschke]

cc @galipremsagar if you have a moment to review

[galipremsagar]

I guess we shouldn't be raising no?:

In [1]: import pandas as pd

In [2]: s = pd.Series([1, 2, 3], name=2)

In [3]: pd.DataFrame(s)
Out[3]: 
   2
0  1
1  2
2  3

In [4]: pd.DataFrame(s, columns=[])
Out[4]: 
Empty DataFrame
Columns: []
Index: []

In [5]: pd.DataFrame(s, columns=[2])
Out[5]: 
   2
0  1
1  2
2  3

In [6]: pd.DataFrame(s, columns=[2, 1])
Out[6]: 
   2    1
0  1  NaN
1  2  NaN
2  3  NaN

In [7]: pd.DataFrame(s, columns=[1])
Out[7]: 
Empty DataFrame
Columns: [1]
Index: []

[mroeschke]

Yeah I guess it's this very narrow use case that should only raise. (I'm not sure of the history why the other cases are allowed)