Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move cpp/src/hash/hash_allocator.cuh to include/cudf/hashing/detail #14163

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Move cpp/src/hash/hash_allocator.cuh to include/cudf/hashing/detail #14163

merged 3 commits into from
Sep 25, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Sep 21, 2023 •
edited
Loading

Description

Moves cpp/src/hash/hash_allocator.cuh to include/cudf/hashing/detail so it may be more accessible from non-src/hash source files.
Also, found cpp/src/hash/helper_functions.hpp used in the same way a moved that one as well.
No functional changes, just headers moved and includes fixed up.

Reference: #13930 (comment)

Closes #14143

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 21, 2023
@davidwendt davidwendt requested a review from a team as a code owner September 21, 2023 20:35
@davidwendt davidwendt self-assigned this Sep 21, 2023
PointKernel
PointKernel approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanups. Thanks!

@davidwendt
Copy link
Contributor Author

/merge

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 3f47b5d into rapidsai:branch-23.10 Sep 25, 2023
54 checks passed
@davidwendt davidwendt deleted the move-hash-allocator-cuh branch September 25, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@vyasr vyasr vyasr approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move cpp/src/hash/hash_allocator.cuh to include/cudf/hashing/detail directory
3 participants
@davidwendt @vyasr @PointKernel