Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Memcheck error found in JSON_TEST JsonReaderTest.ErrorStrings #14164

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Fix Memcheck error found in JSON_TEST JsonReaderTest.ErrorStrings #14164

merged 4 commits into from
Sep 25, 2023

Conversation

karthikeyann
Copy link
Contributor

Description

Fix missing null mask in string column names parsing. For parsing error, the row is made null. To write output properly, the nulls need to be passed so that they can be skipped during writing output stage in parse_data.
Fixes #14141

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann karthikeyann added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond cuIO cuIO issue 4 - Needs cuIO Reviewer non-breaking Non-breaking change labels Sep 21, 2023
@karthikeyann karthikeyann self-assigned this Sep 21, 2023
@karthikeyann karthikeyann requested a review from a team as a code owner September 21, 2023 20:47
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 21, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@karthikeyann
Copy link
Contributor Author

/ok to test

@karthikeyann
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fe3cab5 into rapidsai:branch-23.10 Sep 25, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@ttnghia ttnghia ttnghia approved these changes

@elstehle elstehle elstehle approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@karthikeyann karthikeyann

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Memcheck error found in JSON_TEST JsonReaderTest.ErrorStrings
5 participants
@karthikeyann @elstehle @ttnghia @davidwendt @vyasr