Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bytes_per_second to distinct_count of stream_compaction nvbench. #14172

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Add bytes_per_second to distinct_count of stream_compaction nvbench. #14172

merged 2 commits into from
Sep 28, 2023

Conversation

Blonck
Copy link
Contributor

@Blonck Blonck commented Sep 22, 2023

This patch relates to #13735.

Benchmark: benchmark_distinct_count.txt

Checklist

@Blonck Blonck requested a review from a team as a code owner September 22, 2023 12:05
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 22, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 22, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 22, 2023
@davidwendt
Copy link
Contributor

/ok to test

@davidwendt
Copy link
Contributor

/ok to test

@harrism
Copy link
Member

harrism commented Sep 25, 2023

/ok to test

@harrism
Copy link
Member

harrism commented Sep 25, 2023

Thanks for the contribution @Blonck! This PR was opened after we entered burndown for 23.10 so @GregoryKimball should decide if this should be merged into 23.10. I suspect it will need to be retargeted to 23.12.

@Blonck
Copy link
Contributor Author

Blonck commented Sep 26, 2023

Hi @harrism, I can just rebase this onto 23.12. It's just a benchmark so there is no need to add it to 23.10.

@Blonck Blonck force-pushed the processed_bytes_stream_distinct_count_nvbench branch from 7495e0f to a6323f2 Compare September 26, 2023 13:28
@Blonck Blonck requested review from a team as code owners September 26, 2023 13:28
@Blonck Blonck changed the base branch from branch-23.10 to branch-23.12 September 26, 2023 13:28
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue conda Java Affects Java cuDF API. labels Sep 26, 2023
@github-actions github-actions bot added the ci label Sep 26, 2023
@harrism
Copy link
Member

harrism commented Sep 26, 2023

/ok to test

@harrism
Copy link
Member

harrism commented Sep 26, 2023

/ok to test

@github-actions github-actions bot removed Python Affects Python cuDF API. CMake CMake build issue conda Java Affects Java cuDF API. labels Sep 26, 2023
@vyasr
Copy link
Contributor

vyasr commented Sep 28, 2023

/merge

@rapids-bot rapids-bot bot merged commit 23d24d4 into rapidsai:branch-23.12 Sep 28, 2023
54 checks passed
@vyasr
Copy link
Contributor

vyasr commented Sep 28, 2023

Thanks @Blonck!

@GregoryKimball GregoryKimball mentioned this pull request Nov 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Blonck @davidwendt @harrism @vyasr @karthikeyann