-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strings::contains() for multiple scalar search targets #16641
strings::contains() for multiple scalar search targets #16641
Commits on Aug 22, 2024
-
strings::contains() for multiple search targets
This commit adds a new `strings::contains()` overload that allows for the search of multiple scalar search targets in the same call. The trick here is that a new kernel has been introduced, to extend the "string-per-warp" approach to search for multiple search keys in the same kernel. This approach allows CUDF to potentially reduce the number of kernels launched for `string::contains()` by a factor of `N`, if all the search keys can be specified in the same call. This helps reduce the kernel-launch overheads for processes that do large numbers of calls to `string::contains()`. Signed-off-by: MithunR <[email protected]> Changed iteration order, for better cache performance. More optimizations: 1. Removed calls to `thrust::fill()`. The bool values are now explicitly written in the kernel. 2. Switched host-device copy to use async. Revert "More optimizations:" This reverts commit c0e355c. This commit was wrong: The thrust::fill() checks for empty target strings. If removed, we'll need to check for empty target strings for every input string row. This was better done the old way. More improvements: 1. Removed thrust::fill call. Setting values explicitly in the kernel. 2. Switched from using io::hostdevice_vector to rmm::device_uvector. The string_view allocation is tiny. This has helped reduce the time spent in strings::contains(). For small strings, delegate to thread-per-string algo.
Configuration menu - View commit details
-
Copy full SHA for f4924a9 - Browse repository at this point
Copy the full SHA f4924a9View commit details -
Signed-off-by: Chong Gao <[email protected]>
Chong Gao committedAug 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 1022c83 - Browse repository at this point
Copy the full SHA 1022c83View commit details -
Chong Gao committed
Aug 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 45170e9 - Browse repository at this point
Copy the full SHA 45170e9View commit details
Commits on Aug 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7e2aa43 - Browse repository at this point
Copy the full SHA 7e2aa43View commit details
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 32e1329 - Browse repository at this point
Copy the full SHA 32e1329View commit details
Commits on Aug 29, 2024
-
Use new approach to improve perf: index the first chars in the targets
Chong Gao committedAug 29, 2024 Configuration menu - View commit details
-
Copy full SHA for be6985b - Browse repository at this point
Copy the full SHA be6985bView commit details -
Fix comments; Restore a test change
Chong Gao committedAug 29, 2024 Configuration menu - View commit details
-
Copy full SHA for be7a1e2 - Browse repository at this point
Copy the full SHA be7a1e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b635f6 - Browse repository at this point
Copy the full SHA 6b635f6View commit details -
Chong Gao committed
Aug 29, 2024 Configuration menu - View commit details
-
Copy full SHA for 479788c - Browse repository at this point
Copy the full SHA 479788cView commit details
Commits on Aug 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 543a1f6 - Browse repository at this point
Copy the full SHA 543a1f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1da8b0 - Browse repository at this point
Copy the full SHA f1da8b0View commit details -
Update test cases; update benchmark tests
Chong Gao committedAug 30, 2024 Configuration menu - View commit details
-
Copy full SHA for 06ba14c - Browse repository at this point
Copy the full SHA 06ba14cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 14418d7 - Browse repository at this point
Copy the full SHA 14418d7View commit details
Commits on Sep 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 814e002 - Browse repository at this point
Copy the full SHA 814e002View commit details -
Chong Gao committed
Sep 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 587ce34 - Browse repository at this point
Copy the full SHA 587ce34View commit details -
Chong Gao committed
Sep 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 470355f - Browse repository at this point
Copy the full SHA 470355fView commit details
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4b41ead - Browse repository at this point
Copy the full SHA 4b41eadView commit details -
Chong Gao committed
Sep 4, 2024 Configuration menu - View commit details
-
Copy full SHA for e56a122 - Browse repository at this point
Copy the full SHA e56a122View commit details
Commits on Sep 5, 2024
-
Chong Gao committed
Sep 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 31f4822 - Browse repository at this point
Copy the full SHA 31f4822View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88d351d - Browse repository at this point
Copy the full SHA 88d351dView commit details
Commits on Sep 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7836c33 - Browse repository at this point
Copy the full SHA 7836c33View commit details -
Split targets to small groups to save shared memory when num of targe…
…ts is large
Chong Gao committedSep 6, 2024 Configuration menu - View commit details
-
Copy full SHA for 6ae2c00 - Browse repository at this point
Copy the full SHA 6ae2c00View commit details
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 542e1ff - Browse repository at this point
Copy the full SHA 542e1ffView commit details
Commits on Sep 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ab5ef90 - Browse repository at this point
Copy the full SHA ab5ef90View commit details
Commits on Sep 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for da1d92b - Browse repository at this point
Copy the full SHA da1d92bView commit details -
Fix bug when strings are long: returns all falses.
Chong Gao committedSep 11, 2024 Configuration menu - View commit details
-
Copy full SHA for 3324671 - Browse repository at this point
Copy the full SHA 3324671View commit details -
Chong Gao committed
Sep 11, 2024 Configuration menu - View commit details
-
Copy full SHA for 849c093 - Browse repository at this point
Copy the full SHA 849c093View commit details -
Refactor: refine code comments
Chong Gao committedSep 11, 2024 Configuration menu - View commit details
-
Copy full SHA for 85e8b17 - Browse repository at this point
Copy the full SHA 85e8b17View commit details
Commits on Sep 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ce4450d - Browse repository at this point
Copy the full SHA ce4450dView commit details -
Fix bug: illegal memory access
Chong Gao committedSep 14, 2024 Configuration menu - View commit details
-
Copy full SHA for 9fc9398 - Browse repository at this point
Copy the full SHA 9fc9398View commit details -
Chong Gao committed
Sep 14, 2024 Configuration menu - View commit details
-
Copy full SHA for b33d692 - Browse repository at this point
Copy the full SHA b33d692View commit details -
Optimize the perf for indexing first chars
Chong Gao committedSep 14, 2024 Configuration menu - View commit details
-
Copy full SHA for 6741bef - Browse repository at this point
Copy the full SHA 6741befView commit details -
Chong Gao committed
Sep 14, 2024 Configuration menu - View commit details
-
Copy full SHA for 330e828 - Browse repository at this point
Copy the full SHA 330e828View commit details -
Chong Gao committed
Sep 14, 2024 Configuration menu - View commit details
-
Copy full SHA for d216993 - Browse repository at this point
Copy the full SHA d216993View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eb6744f - Browse repository at this point
Copy the full SHA eb6744fView commit details -
Chong Gao committed
Sep 18, 2024 Configuration menu - View commit details
-
Copy full SHA for a32c54d - Browse repository at this point
Copy the full SHA a32c54dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8391239 - Browse repository at this point
Copy the full SHA 8391239View commit details -
Chong Gao committed
Sep 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 5caf782 - Browse repository at this point
Copy the full SHA 5caf782View commit details
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 41fb9ae - Browse repository at this point
Copy the full SHA 41fb9aeView commit details