Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate support for directly accessing logger #16964

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Deprecate support for directly accessing logger #16964

merged 4 commits into from
Oct 4, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 1, 2024 •
edited
Loading

Description

This PR removes support for accessing cudf's underlying spdlog logger directly.

Contributes to rapidsai/build-planning#104

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function breaking Breaking change labels Oct 1, 2024
@vyasr vyasr self-assigned this Oct 1, 2024
@vyasr vyasr requested a review from a team as a code owner October 1, 2024 16:34
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 1, 2024
@vyasr
Copy link
Contributor Author

vyasr commented Oct 4, 2024

/merge

@rapids-bot rapids-bot bot merged commit a8da1ff into rapidsai:branch-24.12 Oct 4, 2024
100 checks passed
@vyasr vyasr deleted the feat/deprecate_spdlog_logger branch October 4, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@PointKernel PointKernel PointKernel approved these changes

@ttnghia ttnghia ttnghia approved these changes

Assignees

@vyasr vyasr

Labels
breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @ttnghia @PointKernel @davidwendt