Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nvcomp to 4.1.0.6 #17201

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Upgrade nvcomp to 4.1.0.6 #17201

merged 4 commits into from
Oct 30, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Oct 29, 2024 •
edited
Loading

Description

This updates cudf to use nvcomp 4.1.0.6.

The version is updated in rapids-cmake in rapidsai/rapids-cmake#709.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the CMake CMake build issue label Oct 29, 2024
@bdice bdice added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Oct 29, 2024
@bdice bdice mentioned this pull request Oct 29, 2024
Merged
7 tasks
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 29, 2024
bdice
bdice commented Oct 30, 2024
View reviewed changes
rapids_config.cmake Outdated Show resolved Hide resolved
@bdice bdice marked this pull request as ready for review October 30, 2024 13:39
@bdice bdice requested a review from a team as a code owner October 30, 2024 13:39
@bdice bdice requested a review from AyodeAwe October 30, 2024 13:39
@github-actions github-actions bot removed CMake CMake build issue labels Oct 30, 2024
@bdice bdice removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Oct 30, 2024
@bdice bdice changed the title Test nvcomp 4.1.0.6 Upgrade nvcomp to 4.1.0.6 Oct 30, 2024
@bdice bdice added feature request New feature or request non-breaking Non-breaking change labels Oct 30, 2024
jameslamb
jameslamb approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving you a packaging-codeowners approval, looks good to me and I've been following along with the testing you were doing.

@jameslamb jameslamb removed the request for review from AyodeAwe October 30, 2024 14:11
@bdice
Copy link
Contributor Author

bdice commented Oct 30, 2024

/merge

@rapids-bot rapids-bot bot merged commit 6c2eb4e into rapidsai:branch-24.12 Oct 30, 2024
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@jameslamb jameslamb jameslamb approved these changes

Assignees

@bdice bdice

Labels
feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @jameslamb @AyodeAwe