Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move detail header floating_conversion.hpp to detail subdirectory #17209

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Oct 30, 2024

Description

Moves the 'cudf/fixed_point/floating_conversion.hpp' to cudf/fixed_point/detail/ subdirectory since it only contains declarations and definition in the detail namespace.
It had previously been its own module. https://docs.rapids.ai/api/libcudf/stable/modules.html

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Oct 30, 2024
@davidwendt davidwendt self-assigned this Oct 30, 2024
@davidwendt davidwendt requested a review from a team as a code owner October 30, 2024 14:54
@davidwendt davidwendt changed the title Move fixed-point float-conversion doxygen under fixed-point module Move detail header floating_conversion.hpp to detail subdirectory Oct 30, 2024
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidwendt
Copy link
Contributor Author

FYI: This will break spark-rapids-jni build as the header is used in https://github.com/NVIDIA/spark-rapids-jni/blob/7ee7b1c20fd473b6b976f4d36bbfeaaebcc29aaf/src/main/cpp/src/decimal_utils.cu#L24.

I will mark this breaking for this. Perhaps you could put a PR up in spark-rapids?
The file should not have been in the public API directory since it only has detail functions in it.

@davidwendt davidwendt added breaking Breaking change and removed non-breaking Non-breaking change labels Oct 31, 2024
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f99ef41 into rapidsai:branch-24.12 Oct 31, 2024
113 checks passed
@davidwendt davidwendt deleted the fix-fp2float-doxygen branch October 31, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team breaking Breaking change doc Documentation libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants