Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move strings::concatenate benchmark to nvbench #17211

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Move strings::concatenate benchmark to nvbench #17211

merged 1 commit into from
Oct 31, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Moves the cudf::strings::concatenate benchmark source from google-bench to nvbench.
This also removes the restrictions on the parameters to allows specifying arbitrary number of rows and string width.

Reference #16948

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 30, 2024
@davidwendt davidwendt self-assigned this Oct 30, 2024
@davidwendt davidwendt requested a review from a team as a code owner October 30, 2024 17:37
@github-actions github-actions bot added the CMake CMake build issue label Oct 30, 2024
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e512258 into rapidsai:branch-24.12 Oct 31, 2024
103 checks passed
@davidwendt davidwendt deleted the strings-combine-nvbench branch October 31, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@ttnghia ttnghia ttnghia approved these changes

@harrism harrism harrism approved these changes

@pmattione-nvidia pmattione-nvidia Awaiting requested review from pmattione-nvidia pmattione-nvidia is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @harrism @ttnghia @PointKernel