Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java JNI for Multiple contains #17281

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Java JNI for Multiple contains #17281

merged 6 commits into from
Nov 14, 2024

Conversation

res-life
Copy link
Contributor

@res-life res-life commented Nov 8, 2024 •
edited
Loading

Description

This is Java JNI interface for multiple contains PR

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@res-life res-life requested a review from a team as a code owner November 8, 2024 12:00
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 8, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Java Affects Java cuDF API. label Nov 8, 2024
@res-life res-life added feature request New feature or request non-breaking Non-breaking change labels Nov 8, 2024
@res-life
Copy link
Contributor Author

/ok to test

abellina
abellina reviewed Nov 13, 2024
View reviewed changes
java/src/main/java/ai/rapids/cudf/ColumnView.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnView.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnView.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnView.java Outdated Show resolved Hide resolved
java/src/main/native/src/ColumnViewJni.cpp Outdated Show resolved Hide resolved
revans2
revans2 reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine with me. I agree with the comments by @abellina

abellina
abellina approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abellina
Copy link
Contributor

/ok to test

1 similar comment
@res-life
Copy link
Contributor Author

/ok to test

@revans2
Copy link
Contributor

revans2 commented Nov 14, 2024

/merge

@rapids-bot rapids-bot bot merged commit 4cd40ee into rapidsai:branch-24.12 Nov 14, 2024
91 checks passed
@res-life res-life deleted the multiple-contains-jni branch November 15, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

@abellina abellina abellina approved these changes

Assignees

@res-life res-life

Labels
feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@res-life @abellina @revans2