Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update strings/text source to use grid_1d for thread/block/stride calculations #17404

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Update strings/text source to use grid_1d for thread/block/stride calculations #17404

merged 5 commits into from
Nov 26, 2024

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Nov 21, 2024 •
edited
Loading

Description

Replaces threadIdx.x + blockDim.x * blockIdx.x logic with grid_1d::global_thread_id() and blockDim.x * gridDim.x with grid_1d::grid_stride() in libcudf strings and text source.

Reference #10368

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 21, 2024
@davidwendt davidwendt self-assigned this Nov 21, 2024
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 25, 2024
@davidwendt davidwendt marked this pull request as ready for review November 25, 2024 15:53
@davidwendt davidwendt requested a review from a team as a code owner November 25, 2024 15:53
bdice
bdice approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from one comment/question.

@GregoryKimball GregoryKimball mentioned this pull request Nov 25, 2024
Open
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d10eae7 into rapidsai:branch-25.02 Nov 26, 2024
105 of 111 checks passed
@davidwendt davidwendt deleted the remove-blockdim-strings branch November 26, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaseeb123 mhaseeb123 mhaseeb123 approved these changes

@PointKernel PointKernel PointKernel approved these changes

@bdice bdice bdice approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @bdice @PointKernel @mhaseeb123