Apply clang-tidy autofixes from new rules #17431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
libcudf
vuule
reviewed
Nov 23, 2024
vuule
reviewed
Nov 23, 2024
vyasr
force-pushed
the
chore/autofix_clang_tidy
branch
from
8955623 to
7111ae2
Compare
Co-authored-by: Vukasin Milovanovic <[email protected]>
bdice
approved these changes
Dec 3, 2024
|
/merge |
|
Discovered this broke libcudf compilation when libcudf logging is disabled, filed #17510. |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
Adds `[[maybe_unused]]` to the `compression_type_name` function to prevent the warning/error. Error/warning introduced in #17431 Closes #17510 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Muhammad Haseeb (https://github.com/mhaseeb123) - MithunR (https://github.com/mythrocks) - Vukasin Milovanovic (https://github.com/vuule) - Jason Lowe (https://github.com/jlowe) URL: #17512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains all of clang-tidy's autofixes for the rules outlined in #17410. In the process I simplified the process of performing autofixes locally.
Checklist