Remove cudf._lib.json in favor of inlining pylibcudf #17443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
wence-
reviewed
Nov 26, 2024
python/cudf/cudf/io/json.py
Outdated
Comment on lines
35
to
49
| def _update_col_struct_field_names( | ||
| col: ColumnBase, child_names: dict | ||
| ) -> ColumnBase: | ||
| if col.children: | ||
| children = list(col.children) | ||
| for i, (child, names) in enumerate( | ||
| zip(children, child_names.values()) | ||
| ): | ||
| children[i] = _update_col_struct_field_names(child, names) | ||
| col.set_base_children(tuple(children)) | ||
|
|
||
| if isinstance(col.dtype, cudf.StructDtype): | ||
| col = col._rename_fields(child_names.keys()) # type: ignore[attr-defined] | ||
|
|
||
| return col |
There was a problem hiding this comment.
I guess it is OK that we update names in-place, but it is a minor potential footgun for two columns that share data (but in theory could have different names).
Matt711
approved these changes
Nov 28, 2024
| compression="infer", | ||
| byte_range=None, | ||
| keep_quotes=False, | ||
| byte_range: None | list[int] = None, |
There was a problem hiding this comment.
Very nit-picky. Do you have a preference?
Suggested change
| byte_range: None | list[int] = None, | |
| byte_range: list[int] | None = None, |
There was a problem hiding this comment.
I don't have a preference in particular. I agree that your suggestion looks better
| ) -> None: | ||
| for name, child_names in child_names_dict.items(): | ||
| col = df._data[name] | ||
| df._data[name] = _update_col_struct_field_names(col, child_names) |
There was a problem hiding this comment.
Just thinking out loud based on @wence- review. We probably don't want to eagerly copy, so maybe we can optionally copy if the column and children share data?
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #17317
Checklist