Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exec_policy_nosync in write_json #17445

Open
wants to merge 2 commits into
base: branch-25.02
Choose a base branch
from
Open

Use exec_policy_nosync in write_json #17445

wants to merge 2 commits into from

Conversation

karthikeyann
Copy link
Contributor

Description

Part of #12086
Replaced rmm::exec_policy with rmm::exec_policy_nosync in write_json

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 26, 2024
@karthikeyann karthikeyann requested a review from a team as a code owner November 26, 2024 07:28
@karthikeyann karthikeyann mentioned this pull request Nov 26, 2024
Merged
3 tasks
shrshi
shrshi reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@shrshi shrshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! One question -

cpp/src/io/json/write_json.cu Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrshi shrshi shrshi approved these changes

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@vuule vuule Awaiting requested review from vuule

Assignees

@karthikeyann karthikeyann

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthikeyann @shrshi @vuule