Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NumPy <2 pin, remove proj pin #1441

Merged
merged 31 commits into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
25a231d
Remove NumPy <2 pin.
seberg Aug 19, 2024
6a5eaaa
Include pre-release identifier for upper pin
seberg Aug 20, 2024
e6fc59e
Merge branch 'branch-24.10' into my_new_branch
bdice Aug 21, 2024
a5dd392
Merge branch 'branch-24.10' into my_new_branch
seberg Aug 23, 2024
aac2eed
merge branch-24.10
jameslamb Aug 29, 2024
44bf741
Merge branch 'branch-24.10' into my_new_branch
jakirkham Aug 30, 2024
b98786e
temporarily require numpy>=2.1.0 to try to get a solver error
jameslamb Aug 30, 2024
c1f5845
temporarily bump cupy floor
jameslamb Aug 30, 2024
a58d1e6
Add temporary llvmlite pin for possibly clear resolver error
seberg Sep 10, 2024
d4d327c
Reduce temporary numpy pin to 2.0.0 since 2.1 collides with numba
seberg Sep 10, 2024
4701748
Undo testing pin in meta.yaml
seberg Sep 13, 2024
1616679
Merge branch 'branch-24.10' into my_new_branch
seberg Sep 14, 2024
95dbc6f
remove final llvmlite pin and remove cupy pin again for now
seberg Sep 14, 2024
0aa2b4e
relax proj pin
jameslamb Sep 18, 2024
03bd1ce
Merge branch 'branch-24.10' of github.com:rapidsai/cuspatial into fmt…
jameslamb Sep 19, 2024
1b036ea
only run build jobs
jameslamb Sep 19, 2024
9a392e9
Merge branch 'fmt-and-spdlog' into my_new_branch
jameslamb Sep 19, 2024
eef38f8
fix dependency graph
jameslamb Sep 19, 2024
4f0d0d6
comment out more tests
jameslamb Sep 19, 2024
47b8b14
try running some tests, to see if conda env solves
jameslamb Sep 19, 2024
c4aacfb
move numpy floor back to 1.23, for integration testing
jameslamb Sep 19, 2024
b73df94
run all CI
jameslamb Sep 20, 2024
9175c84
Update conda/recipes/cuspatial/meta.yaml
jameslamb Sep 20, 2024
b8996cf
Merge branch 'my_new_branch' of github.com:seberg/cuspatial into my_n…
jameslamb Sep 20, 2024
c967d10
pre-commit
jameslamb Sep 20, 2024
7afd894
skip flake8 until https://github.com/rapidsai/cuspatial/pull/1458 is …
jameslamb Sep 20, 2024
26313e3
restore flake8
jameslamb Sep 20, 2024
c1db920
Merge branch 'branch-24.10' into my_new_branch
jameslamb Sep 20, 2024
2a73f91
remove testing-only changes [skip ci]
jameslamb Sep 23, 2024
864fe66
remove testing scripts [skip ci]
jameslamb Sep 23, 2024
218cc31
actually run CI
jameslamb Sep 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 52 additions & 52 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,46 +12,46 @@ concurrency:
jobs:
pr-builder:
needs:
- checks
# - checks
- conda-cpp-build
- conda-cpp-checks
- conda-cpp-tests
# - conda-cpp-checks
# - conda-cpp-tests
- conda-python-build
- conda-python-tests
- conda-notebook-tests
- docs-build
# - docs-build
- wheel-build-cuspatial
- wheel-build-libcuspatial
- wheel-tests-cuspatial
# - wheel-tests-cuspatial
- wheel-build-cuproj
- wheel-tests-cuproj
# - wheel-tests-cuproj
- devcontainer
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
checks:
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
with:
enable_check_generated_files: false
# checks:
# secrets: inherit
# uses: rapidsai/shared-workflows/.github/workflows/[email protected]
# with:
# enable_check_generated_files: false
conda-cpp-build:
needs: checks
# needs: checks
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
with:
build_type: pull-request
conda-cpp-checks:
needs: conda-cpp-build
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
with:
build_type: pull-request
enable_check_symbols: true
conda-cpp-tests:
needs: conda-cpp-build
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
with:
build_type: pull-request
# conda-cpp-checks:
# needs: conda-cpp-build
# secrets: inherit
# uses: rapidsai/shared-workflows/.github/workflows/[email protected]
# with:
# build_type: pull-request
# enable_check_symbols: true
# conda-cpp-tests:
# needs: conda-cpp-build
# secrets: inherit
# uses: rapidsai/shared-workflows/.github/workflows/[email protected]
# with:
# build_type: pull-request
conda-python-build:
needs: conda-cpp-build
secrets: inherit
Expand All @@ -74,18 +74,18 @@ jobs:
arch: "amd64"
container_image: "rapidsai/ci-conda:latest"
run_script: "ci/test_notebooks.sh"
docs-build:
needs: conda-python-build
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
with:
build_type: pull-request
node_type: "gpu-v100-latest-1"
arch: "amd64"
container_image: "rapidsai/ci-conda:latest"
run_script: "ci/build_docs.sh"
# docs-build:
# needs: conda-python-build
# secrets: inherit
# uses: rapidsai/shared-workflows/.github/workflows/[email protected]
# with:
# build_type: pull-request
# node_type: "gpu-v100-latest-1"
# arch: "amd64"
# container_image: "rapidsai/ci-conda:latest"
# run_script: "ci/build_docs.sh"
wheel-build-libcuspatial:
needs: checks
# needs: checks
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
with:
Expand All @@ -94,33 +94,33 @@ jobs:
build_type: pull-request
script: ci/build_wheel_libcuspatial.sh
wheel-build-cuspatial:
needs: [checks, wheel-build-libcuspatial]
needs: [wheel-build-libcuspatial]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
with:
build_type: pull-request
script: ci/build_wheel_cuspatial.sh
wheel-tests-cuspatial:
needs: wheel-build-cuspatial
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
with:
build_type: pull-request
script: ci/test_wheel_cuspatial.sh
# wheel-tests-cuspatial:
# needs: wheel-build-cuspatial
# secrets: inherit
# uses: rapidsai/shared-workflows/.github/workflows/[email protected]
# with:
# build_type: pull-request
# script: ci/test_wheel_cuspatial.sh
wheel-build-cuproj:
needs: checks
# needs: checks
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
with:
build_type: pull-request
script: ci/build_wheel_cuproj.sh
wheel-tests-cuproj:
needs: [wheel-build-cuspatial, wheel-build-cuproj]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
with:
build_type: pull-request
script: ci/test_wheel_cuproj.sh
# wheel-tests-cuproj:
# needs: [wheel-build-cuspatial, wheel-build-cuproj]
# secrets: inherit
# uses: rapidsai/shared-workflows/.github/workflows/[email protected]
# with:
# build_type: pull-request
# script: ci/test_wheel_cuproj.sh
devcontainer:
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/[email protected]
Expand Down
3 changes: 3 additions & 0 deletions ci/build_cpp.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ source rapids-date-string

export CMAKE_GENERATOR=Ninja

cd "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"/../
source ./ci/use_conda_packages_from_prs.sh

rapids-print-env

rapids-logger "Begin cpp build"
Expand Down
3 changes: 3 additions & 0 deletions ci/build_python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ source rapids-date-string

export CMAKE_GENERATOR=Ninja

cd "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"/../
source ./ci/use_conda_packages_from_prs.sh

rapids-print-env

package_dir="python"
Expand Down
2 changes: 2 additions & 0 deletions ci/build_wheel.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ esac
source rapids-configure-sccache
source rapids-date-string

source ./ci/use_wheels_from_prs.sh

rapids-generate-version > ./VERSION

RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen ${RAPIDS_CUDA_VERSION})"
Expand Down
2 changes: 2 additions & 0 deletions ci/build_wheel_cuproj.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@

set -euo pipefail

source ./ci/use_wheels_from_prs.sh

ci/build_wheel.sh cuproj python/cuproj python
4 changes: 3 additions & 1 deletion ci/build_wheel_cuspatial.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,15 @@ set -euo pipefail

RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen ${RAPIDS_CUDA_VERSION})"

source ./ci/use_wheels_from_prs.sh

# Downloads libcuspatial wheel from this current build,
# then ensures 'cuspatial' wheel builds always use the 'libcuspatial' just built in the same CI run.
#
# Using env variable PIP_CONSTRAINT is necessary to ensure the constraints
# are used when creating the isolated build environment.
RAPIDS_PY_WHEEL_NAME="libcuspatial_${RAPIDS_PY_CUDA_SUFFIX}" rapids-download-wheels-from-s3 cpp /tmp/libcuspatial_dist
echo "libcuspatial-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo /tmp/libcuspatial_dist/libcuspatial_*.whl)" > /tmp/constraints.txt
echo "libcuspatial-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo /tmp/libcuspatial_dist/libcuspatial_*.whl)" >> /tmp/constraints.txt
export PIP_CONSTRAINT="/tmp/constraints.txt"

ci/build_wheel.sh cuspatial python/cuspatial python
2 changes: 2 additions & 0 deletions ci/build_wheel_libcuspatial.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@

set -euo pipefail

source ./ci/use_wheels_from_prs.sh

ci/build_wheel.sh libcuspatial python/libcuspatial cpp
2 changes: 1 addition & 1 deletion ci/test_cpp.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
set -euo pipefail

. /opt/conda/etc/profile.d/conda.sh

source "$(dirname "$0")/use_conda_packages_from_prs.sh"

rapids-logger "Downloading artifacts from previous jobs"
CPP_CHANNEL=$(rapids-download-conda-from-s3 cpp)
Expand Down
2 changes: 2 additions & 0 deletions ci/test_notebooks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ set -eEuo pipefail

. /opt/conda/etc/profile.d/conda.sh

source "$(dirname "$0")/use_conda_packages_from_prs.sh"

rapids-logger "Downloading artifacts from previous jobs"
CPP_CHANNEL=$(rapids-download-conda-from-s3 cpp)
PYTHON_CHANNEL=$(rapids-download-conda-from-s3 python)
Expand Down
1 change: 1 addition & 0 deletions ci/test_python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
set -euo pipefail

. /opt/conda/etc/profile.d/conda.sh
source "$(dirname "$0")/use_conda_packages_from_prs.sh"

rapids-logger "Downloading artifacts from previous jobs"
CPP_CHANNEL=$(rapids-download-conda-from-s3 cpp)
Expand Down
2 changes: 2 additions & 0 deletions ci/test_wheel_cuproj.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ set -eou pipefail
mkdir -p ./dist
RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen ${RAPIDS_CUDA_VERSION})"

source ./ci/use_wheels_from_prs.sh

# Download the cuproj and cuspatial built in the previous step
RAPIDS_PY_WHEEL_NAME="cuproj_${RAPIDS_PY_CUDA_SUFFIX}" rapids-download-wheels-from-s3 python ./dist
RAPIDS_PY_WHEEL_NAME="cuspatial_${RAPIDS_PY_CUDA_SUFFIX}" rapids-download-wheels-from-s3 python ./dist
Expand Down
2 changes: 2 additions & 0 deletions ci/test_wheel_cuspatial.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ set -eou pipefail
mkdir -p ./dist
RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen ${RAPIDS_CUDA_VERSION})"

source ./ci/use_wheels_from_prs.sh

# Download the cuspatial and libcuspatial built in the previous step
RAPIDS_PY_WHEEL_NAME="cuspatial_${RAPIDS_PY_CUDA_SUFFIX}" rapids-download-wheels-from-s3 python ./dist
RAPIDS_PY_WHEEL_NAME="libcuspatial_${RAPIDS_PY_CUDA_SUFFIX}" rapids-download-wheels-from-s3 cpp ./dist
Expand Down
15 changes: 15 additions & 0 deletions ci/use_conda_packages_from_prs.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#!/bin/bash

LIBRMM_CHANNEL=$(rapids-get-pr-conda-artifact rmm 1678 cpp)
RMM_CHANNEL=$(rapids-get-pr-conda-artifact rmm 1678 python)

CUDF_CPP_CHANNEL=$(rapids-get-pr-conda-artifact cudf 16806 cpp)
CUDF_PYTHON_CHANNEL=$(rapids-get-pr-conda-artifact cudf 16806 python)

# UCXX_CHANNEL=$(rapids-get-pr-conda-artifact ucxx 278 cpp)

conda config --system --add channels "${LIBRMM_CHANNEL}"
conda config --system --add channels "${RMM_CHANNEL}"
conda config --system --add channels "${CUDF_CPP_CHANNEL}"
conda config --system --add channels "${CUDF_PYTHON_CHANNEL}"
# conda config --system --add channels "${UCXX_CHANNEL}"
58 changes: 58 additions & 0 deletions ci/use_wheels_from_prs.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
#!/bin/bash

RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen ${RAPIDS_CUDA_VERSION})"

LIBRMM_CHANNEL=$(
RAPIDS_PY_WHEEL_NAME=rmm_${RAPIDS_PY_CUDA_SUFFIX} rapids-get-pr-wheel-artifact rmm 1678 cpp
)
RMM_CHANNEL=$(
RAPIDS_PY_WHEEL_NAME=rmm_${RAPIDS_PY_CUDA_SUFFIX} rapids-get-pr-wheel-artifact rmm 1678 python
)

# UCXX_CHANNEL=$(
# RAPIDS_PY_WHEEL_NAME=ucxx_${RAPIDS_PY_CUDA_SUFFIX} rapids-get-pr-wheel-artifact ucxx 278 python
# )
# LIBUCXX_CHANNEL=$(
# RAPIDS_PY_WHEEL_NAME=libucxx_${RAPIDS_PY_CUDA_SUFFIX} rapids-get-pr-wheel-artifact ucxx 278 cpp
# )
# DISTRIBUTED_UCXX_CHANNEL=$(
# RAPIDS_PY_WHEEL_NAME=distributed_ucxx_${RAPIDS_PY_CUDA_SUFFIX} rapids-get-pr-wheel-artifact ucxx 278 python
# )

CUDF_CHANNEL=$(
RAPIDS_PY_WHEEL_NAME=cudf_${RAPIDS_PY_CUDA_SUFFIX} rapids-get-pr-wheel-artifact cudf 16806 python
)
LIBCUDF_CHANNEL=$(
RAPIDS_PY_WHEEL_NAME=libcudf_${RAPIDS_PY_CUDA_SUFFIX} rapids-get-pr-wheel-artifact cudf 16806 cpp
)
PYLIBCUDF_CHANNEL=$(
RAPIDS_PY_WHEEL_NAME=pylibcudf_${RAPIDS_PY_CUDA_SUFFIX} rapids-get-pr-wheel-artifact cudf 16806 python
)
DASK_CUDF_CHANNEL=$(
RAPIDS_PY_WHEEL_NAME=dask_cudf_${RAPIDS_PY_CUDA_SUFFIX} \
RAPIDS_PY_WHEEL_PURE=1 \
rapids-get-pr-wheel-artifact cudf 16806 python
)

# RAFT_DASK_CHANNEL=$(
# RAPIDS_PY_WHEEL_NAME=raft_dask_${RAPIDS_PY_CUDA_SUFFIX} rapids-get-pr-wheel-artifact raft 2433 python
# )
# PYLIBRAFT_CHANNEL=$(
# RAPIDS_PY_WHEEL_NAME=pylibraft_${RAPIDS_PY_CUDA_SUFFIX} rapids-get-pr-wheel-artifact raft 2433 python
# )

cat > /tmp/constraints.txt <<EOF
librmm-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${LIBRMM_CHANNEL}/librmm_*.whl)
rmm-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${RMM_CHANNEL}/rmm_*.whl)
cudf-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${CUDF_CHANNEL}/cudf_*.whl)
libcudf-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${LIBCUDF_CHANNEL}/libcudf_*.whl)
pylibcudf-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${PYLIBCUDF_CHANNEL}/pylibcudf_*.whl)
dask-cudf-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${DASK_CUDF_CHANNEL}/dask_cudf_*.whl)
EOF

# ucxx-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${UCXX_CHANNEL}/ucxx_*.whl)
# libucxx-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${LIBUCXX_CHANNEL}/libucxx_*.whl)
# distributed-ucxx-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${DISTRIBUTED_UCXX_CHANNEL}/distributed_ucxx_*.whl)
# raft-dask-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${RAFT_DASK_CHANNEL}/raft_dask_*.whl)
# pylibraft-${RAPIDS_PY_CUDA_SUFFIX} @ file://$(echo ${PYLIBRAFT_CHANNEL}/pylibraft_*.whl)
export PIP_CONSTRAINT=/tmp/constraints.txt
4 changes: 2 additions & 2 deletions conda/environments/all_cuda-118_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ dependencies:
- nbsphinx
- ninja
- notebook
- numpy>=1.23,<2.0a0
- numpy>=1.23,<3.0a0
- numpydoc
- nvcc_linux-64=11.8
- osmnx>=1.9.3
- pre-commit
- proj >=9.3.0,<9.3.1.0a0
- proj
- pydata-sphinx-theme!=0.14.2
- pydeck
- pylibcudf==24.10.*,>=0.0.0a0
Expand Down
4 changes: 2 additions & 2 deletions conda/environments/all_cuda-125_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ dependencies:
- nbsphinx
- ninja
- notebook
- numpy>=1.23,<2.0a0
- numpy>=1.23,<3.0a0
- numpydoc
- osmnx>=1.9.3
- pre-commit
- proj >=9.3.0,<9.3.1.0a0
- proj
- pydata-sphinx-theme!=0.14.2
- pydeck
- pylibcudf==24.10.*,>=0.0.0a0
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/cuproj/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ requirements:
- rapids-build-backend >=0.3.0,<0.4.0.dev0
- librmm ={{ minor_version }}
- scikit-build-core >=0.10.0
- proj >=9.3.0,<9.3.1.0a0 # TODO: proj is being held back due to needing spdlog/fmt upgrades to support recent conda-forge builds of tiledb
- proj
- sqlite
run:
{% if cuda_major == "11" %}
Expand Down
2 changes: 1 addition & 1 deletion conda/recipes/cuspatial/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ requirements:
- cudf ={{ minor_version }}
- pylibcudf ={{ minor_version }}
- geopandas >=1.0.0
- numpy >=1.23,<2.0a0
- numpy >=1.23,<3.0a0
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
- python
- rmm ={{ minor_version }}

Expand Down
4 changes: 2 additions & 2 deletions conda/recipes/libcuspatial/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ requirements:
- libcudf ={{ minor_version }}
- librmm ={{ minor_version }}
- sqlite
- proj >=9.3.0,<9.3.1.0a0 # TODO: proj is being held back due to needing spdlog/fmt upgrades to support recent conda-forge builds of tiledb
- proj

outputs:
- name: libcuspatial
Expand Down Expand Up @@ -85,7 +85,7 @@ outputs:
- libcudf ={{ minor_version }}
- librmm ={{ minor_version }}
- sqlite
- proj >=9.3.0,<9.3.1.0a0 # TODO: proj is being held back due to needing spdlog/fmt upgrades to support recent conda-forge builds of tiledb
- proj
test:
commands:
- test -f $PREFIX/lib/libcuspatial.so
Expand Down
Loading
Loading