Type open_http's nbytes as Py_ssize_t
#500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python typically defines size values as `Py_ssize_t`. Leverage this with `nbytes`. Also as `Py_ssize_t` is `signed` it can take negative values. So pick make the `nbytes` default value `-1`. Update internal checks for `nbytes` being passed similarly. This eliminates the overhead associated with a Python object.
jakirkham
added
improvement
|
Superseded with PR: #501 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python typically defines size values as
Py_ssize_t. Leverage this withnbytes. Also asPy_ssize_tissignedit can take negative values. So pick make thenbytesdefault value-1. Update internal checks fornbytesbeing passed similarly. This eliminates the overhead associated with a Python object.