Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly list CUDA libs in Python Conda package #513

Open
wants to merge 8 commits into
base: branch-24.12
Choose a base branch
from

Conversation

jakirkham
Copy link
Member

Explicitly include dependencies on libcufile* and *cudart* in the Python Conda package. These seem to be pulled in implicitly by the C++ package. However as they are dependencies of the Python built shared objects, they should also be listed here.

xef: #378

@jakirkham jakirkham requested a review from a team as a code owner October 23, 2024 18:39
@jakirkham jakirkham added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 23, 2024
@jakirkham
Copy link
Member Author

Am seeing errors like this in the C++ tests. However we really haven't changed anything on the C++ side

Performing async I/O using by-value arguments
File async write: 4096
File async read: 4096
(2759 us)
KvikIO defaults: 
  Compatibility mode: enabled
Write: 8192
Parallel POSIX read (1 threads): 8192
Test project /opt/conda/envs/test/bin/tests/libkvikio
CMake Error at CTestTestfile.cmake:5 (execute_process):
  execute_process given unknown argument "COMMAND_ERROR_IS_FATAL".
    Start 1: cpp_tests


1/1 Test #1: cpp_tests ........................***Failed    0.01 sec
CMake Error: No script specified for argument -P


0% tests passed, 1 tests failed out of 1

Total Test time (real) =   0.01 sec

The following tests FAILED:
	  1 - cpp_tests (Failed)
Errors while running CTest

@madsbk do you have thoughts on what may be happening here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants