-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly list CUDA libs in Python Conda package #513
Open
jakirkham
wants to merge
8
commits into
rapidsai:branch-24.12
Choose a base branch
from
jakirkham:req_conda_py_libcufile-dev
base: branch-24.12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Explicitly list CUDA libs in Python Conda package #513
jakirkham
wants to merge
8
commits into
rapidsai:branch-24.12
from
jakirkham:req_conda_py_libcufile-dev
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
added
improvement
Improves an existing functionality
non-breaking
Introduces a non-breaking change
labels
Oct 23, 2024
jakirkham
force-pushed
the
req_conda_py_libcufile-dev
branch
from
October 23, 2024 21:53
fb76de8
to
3c589fb
Compare
bdice
reviewed
Nov 21, 2024
bdice
approved these changes
Nov 21, 2024
Am seeing errors like this in the C++ tests. However we really haven't changed anything on the C++ side
@madsbk do you have thoughts on what may be happening here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly include dependencies on
libcufile*
and*cudart*
in the Python Conda package. These seem to be pulled in implicitly by the C++ package. However as they are dependencies of the Python built shared objects, they should also be listed here.xef: #378