Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rapids-generate-version for env var #622

Open
wants to merge 3 commits into
base: branch-25.04
Choose a base branch
from
Open

Use rapids-generate-version for env var #622

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
173c62c
Use `rapids-generate-version` for env var
jakirkham Feb 5, 2025
5e9a960
Revert and add comment
jakirkham Feb 10, 2025
6a99b49
Merge branch 'branch-25.04' into use_rapids-generate-version_again
jakirkham Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/build_python.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ conda config --set path_conflict prevent

sccache --zero-stats

RAPIDS_PACKAGE_VERSION=$(head -1 ./VERSION) rapids-conda-retry mambabuild \
RAPIDS_PACKAGE_VERSION=$(rapids-generate-version) rapids-conda-retry mambabuild \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the function is being called once above, hence why I previously just read the output.

Copy link
Member Author

@jakirkham jakirkham Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the line Vyas referenced

kvikio/ci/build_python.sh

Line 16 in 173c62c

rapids-generate-version > ./VERSION

And we need to that line as the VERSION file has to be written out there

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is slightly preferably. I misunderstood the original code, I though that ./VERSION was written just to be read here :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment to that line. Also shared a few examples below

--channel "${CPP_CHANNEL}" \
conda/recipes/kvikio

Expand Down
Loading