-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [DO NOT MERGE] introduce libraft wheels #2531
Draft
jameslamb
wants to merge
26
commits into
rapidsai:branch-25.02
Choose a base branch
from
jameslamb:libraft-wheels
base: branch-25.02
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
5 - DO NOT MERGE
Hold off on merging; see PR for details
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
2 - In Progress
Currenty a work in progress
labels
Dec 17, 2024
This comment was marked as resolved.
This comment was marked as resolved.
jameslamb
changed the title
WIP: introduce libraft wheels
WIP: [DO NOT MERGE] introduce libraft wheels
Dec 17, 2024
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
…nup (#2532) Proposes some cleanup of packaging details, noticed while I was working on #2531 * removes runtime dependencies on `joblib` and `numba` for `raft-dask` - *`raft-dask` doesn't directly import from these libraries, and the git blame didn't suggest any other reason that they were being pinned here* - *checked with `git grep -E 'joblib|numba'` * removes `setup.cfg` files - *these are currently being ignored by tools, in favor of identical configuration in `pyproject.toml` and `.flake8` files* - e.g. https://github.com/rapidsai/raft/blob/bfd190687ee396374b7106d9ac26add73b57b22a/.pre-commit-config.yaml#L16-L19 * packages license files in conda packages - *think these were just missed in the round of PRs like this: rapidsai/cuml#6061 * removes some outdated / inaccurate comments in packaging configs Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) - Corey J. Nolet (https://github.com/cjnolet) URL: #2532
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2 - In Progress
Currenty a work in progress
5 - DO NOT MERGE
Hold off on merging; see PR for details
ci
CMake
cpp
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2360, contributes to rapidsai/build-planning#33.
Proposes packaging
libraft
as a wheel, which is then re-used by:pylibraft-cu{11,12}
andraft-cu{11,12}
(this PR)libcugraph-cu{11,12}
in WIP: [DO NOT MERGE] introduce libcugraph wheels cugraph#4804libcuml-cu{11,12}
in WIP: [DO NOT MERGE] introduce libcuml wheels cuml#6199Notes for Reviewers
If you see this note, that means this is not ready for review.
Dependency Flows
libraft
wheels contain all of:raft
headers (and everything they require)libraft.a
(static library)libraft.so
(shared object)libcugraph
andlibcuml
needlibraft
at build time to statically link againstlibraft.a
.pylibcugraph
,cugraph
, andcuml
needlibraft
at build time just to get the RAFT headers (since those are used inlibcugraph
's andlibcuml
's public headers).Nothing in
cugraph
would needlibraft
at runtime, becauselibcugraph
is statically linked againstlibraft
.Presumably
wholegraph
could follow a similar patternSize changes (CUDA 12, Python 3.12, x86_64)
libraft
.pylibraft
raft-dask
libcugraph
pylibcugraph
cugraph
libcuml
cuml
NOTES: size = compressed, "before" = 2024-12-17 nightlies (rapidsai/cugraph@5c8f850), cugraph libraries from rapidsai/cugraph#4804
how I calculated those (click me)