Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding identify minimum version requirement (#1301)
I ran into an issue with clang-format not being able to run due to the version of identify I had installed. ``` $ pre-commit An error has occurred: InvalidManifestError: ==> At Hook(id='clang-format') ==> At key: types_or ==> At index 9 =====> Type tag 'textproto' is not recognized. Try upgrading identify and pre-commit? ``` This led me to find out that pre-commit only requires version 1, but we require a newer version to work with clang-format. We don't specify that version anywhere, so I tracked down the minimum requirement and added it in our dependencies.yaml and ran pre-commit to update the conda environment files. I verified that version [2.5.19](https://github.com/pre-commit/identify/blob/v2.5.19/identify/extensions.py#L226) did not have textproto, but [2.5.20](https://github.com/pre-commit/identify/blob/v2.5.20/identify/extensions.py#L226) did have it and that is why 2.5.20 is the minimum required version. Authors: - Mike Wilson (https://github.com/hyperbolic2346) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Ray Douglass (https://github.com/raydouglass) URL: #1301
- Loading branch information