Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELEASE] rmm v23.08 #1315

Merged
merged 24 commits into from
Aug 9, 2023
Merged

[RELEASE] rmm v23.08 #1315

merged 24 commits into from
Aug 9, 2023

Conversation

raydouglass
Copy link
Member

❄️ Code freeze for branch-23.08 and v23.08 release

What does this mean?

Only critical/hotfix level issues should be merged into branch-23.08 until release (merging of this PR).

What is the purpose of this PR?

  • Update documentation
  • Allow testing for the new release
  • Enable a means to merge branch-23.08 into main for the release

raydouglass and others added 23 commits May 19, 2023 09:49
@raydouglass
DOC
945f9fb
@GPUtester
Merge pull request #1273 from rapidsai/branch-23.06
913873d 
Forward-merge branch-23.06 to branch-23.08
@vyasr
Unpin scikit-build upper bound (#1275)
3c40cbc 
Remove scikit-build upper bound pinning

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Bradley Dice (https://github.com/bdice)

URL: #1275
@wence-
Remove now-deprecated top-level allocator functions (#1281)
829691c 
We deprecated these functions in 23.04, so there will have been two
releases with deprecation warnings.

Closes #1225.

Authors:
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Bradley Dice (https://github.com/bdice)

URL: #1281
@GPUtester
Merge pull request #1282 from rapidsai/branch-23.06
3217138 
Forward-merge branch-23.06 to branch-23.08
@GPUtester
Merge pull request #1283 from rapidsai/branch-23.06
c34e1ce 
Forward-merge branch-23.06 to branch-23.08
@ajschmidt8
Remove documentation build scripts for Jenkins (#1285)
39a528b 
We recently created new scripts for building documentation with GitHub Actions.

This PR removes the old scripts that were used by Jenkins and are no longer in use.

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1285
@vyasr
Reorder parameters in RMM_EXPECTS (#1286)
8b3e2c4 
Resolves #1172

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Rong Ou (https://github.com/rongou)

URL: #1286
@vyasr
Remove padding from device_memory_resource (#1278)
64da5fe 
This PR removes the `align_up` call that enforces 8B padding on all RMM device memory allocations. Padding, where needed, should be the responsibility of callers, possibly with the help of a padding adapter. It should not be enforced by rmm.

I looked at all other calls to `align_up` in the library but didn't find any others that needed removing. The other calls all seemed to be used to guarantee specific intentional alignment requirements of other memory resources or adapters. I would appreciate verification from reviewers, though.

I've labeled this PR as breaking because it could break consumers that were implicitly relying on the current padding behavior.

Resolves #865
Resolves #1156

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Rong Ou (https://github.com/rongou)
  - Mark Harris (https://github.com/harrism)

URL: #1278
@AyodeAwe
use rapids-upload-docs script (#1288)
53fa74a 
This PR updates the `build_docs.sh` script to use the new consolidatory `rapids-upload-script` [shared script](rapidsai/gha-tools#56). 

The shared script enables docs uploads to applicable S3 buckets for branch. nightly and PR builds.

Authors:
  - Jake Awe (https://github.com/AyodeAwe)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #1288
@GPUtester
Merge pull request #1290 from rapidsai/branch-23.06
417bf14 
Forward-merge branch-23.06 to branch-23.08
@robertmaynard
Ensure logger tests don't generate temp directories in build dir (#1289)
b5203f2 
Corrects a bug introduced in #1277 which caused the logger tests to construct temporary directories in the build directory ( that never go deleted ).

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #1289
@harrism
Use gbench thread_index() accessor to fix replay bench compilation (#…
ea50f90 
…1293)

rapidsai/rapids-cmake#425 updated the google benchmark version to a version that is more than 2 years newer, and the API changed. This PR just changes to use an accessor rather than a public (now private) data member to fix the compilation errors.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Rong Ou (https://github.com/rongou)
  - Bradley Dice (https://github.com/bdice)

URL: #1293
@vyasr
Update to CMake 3.26.4 (#1291)
0c08dd5 
Updates minimum required CMake version to 3.26.4

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Mark Harris (https://github.com/harrism)

URL: #1291
@valgur
Add a missing '#include <array>' in logger.hpp (#1295)
e212256 
For `std::array units{...}`.

Cropped up in conan-io/conan-center-index#17671.

Authors:
  - Martin Valgur (https://github.com/valgur)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Mark Harris (https://github.com/harrism)

URL: #1295
@bdice
RMM: Build CUDA 12 packages (#1223)
d6cc9b8 
This PR builds `librmm` and `rmm` conda packages using CUDA 12. Resolves #1207.

Authors:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - https://github.com/jakirkham

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - https://github.com/jakirkham
  - Robert Maynard (https://github.com/robertmaynard)

URL: #1223
@bdice
Use cuda-version to constrain cudatoolkit. (#1296)
0059926 
This PR changes CUDA 11 packaging to rely on `cuda-version` pinnings to constrain the installed version of `cudatoolkit`.

See also: rapidsai/cudf#13615

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #1296
@vyasr
Stop invoking setup.py (#1300)
5502767 
This PR changes replaces direct invocations of setup.py in build.sh with `pip install` commands since setup.py usage is deprecated. This change will facilitate upcoming changes to our build systems.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Mark Harris (https://github.com/harrism)

URL: #1300
@vyasr
Update linters: remove flake8, add ruff, update cython-lint (#1302)
cfbc678 
The cython-lint change is necessary to unblock runs after the Cython 3.0 update, but it is also a QOL improvement that allows us to remove flake8 usage in Cython files since cython-lint now covers a superset of what flake8 could do for Cython. ruff is (nearly) a superset of flake8 for pure Python and has a wide range of advantages, so this switch is beneficial as well. 

cf. rapidsai/cudf#13699

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Ashwin Srinath (https://github.com/shwina)
  - Mark Harris (https://github.com/harrism)

URL: #1302
@bdice
Revert CUDA 12.0 CI workflows to branch-23.08. (#1303)
4ec6bc6 
This PR reverts changes to the branch of `shared-action-workflows` used for CUDA 12 testing. Now that rapidsai/shared-workflows#101 is merged, we can revert this.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1303
@hyperbolic2346
Adding identify minimum version requirement (#1301)
0a5b86c 
I ran into an issue with clang-format not being able to run due to the version of identify I had installed.
```
$ pre-commit 
An error has occurred: InvalidManifestError: 
==> At Hook(id='clang-format')
==> At key: types_or
==> At index 9
=====> Type tag 'textproto' is not recognized.  Try upgrading identify and pre-commit?
```
This led me to find out that pre-commit only requires version 1, but we require a newer version to work with clang-format. We don't specify that version anywhere, so I tracked down the minimum requirement and added it in our dependencies.yaml and ran pre-commit to update the conda environment files.

I verified that version [2.5.19](https://github.com/pre-commit/identify/blob/v2.5.19/identify/extensions.py#L226) did not have textproto, but [2.5.20](https://github.com/pre-commit/identify/blob/v2.5.20/identify/extensions.py#L226) did have it and that is why 2.5.20 is the minimum required version.

Authors:
  - Mike Wilson (https://github.com/hyperbolic2346)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Ray Douglass (https://github.com/raydouglass)

URL: #1301
@vyasr
Switch to new CI wheel building pipeline (#1305)
81e7a38 
Moves the wheel build and test logic out of the workflow into the repo. This matches conda tests more closely and allows each repo to manage its own wheels more easily.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #1305
@bdice
Fix typo in wheels-test.yaml. (#1310)
b2ed023 
Fixes a typo in the `test.yaml` workflow from #1305.

Nightlies failed here: https://github.com/rapidsai/rmm/actions/runs/5665017238

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #1310
@raydouglass raydouglass requested review from a team as code owners July 28, 2023 14:36
@github-actions github-actions bot added the CMake label Jul 28, 2023
@github-actions github-actions bot added Python Related to RMM Python API conda cpp Pertains to C++ code ci labels Jul 28, 2023
@raydouglass raydouglass merged commit b8a7df1 into main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwharris cwharris Awaiting requested review from cwharris cwharris is a code owner automatically assigned from rapidsai/rmm-cpp-codeowners

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/rmm-cpp-codeowners

Assignees
No one assigned
Labels
ci CMake conda cpp Pertains to C++ code Python Related to RMM Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.