-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefer wheel-provided libraries, use RTLD_LOCAL #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pentschev for why I'm proposing rebuilding 1.14 even though RAPIDS doesn't support it... same as the last time we talked about that: #6 (comment) It's not that much incremental effort, and it ensures all the wheels work the same way regardless of which version you get. I don't feel too strongly about that, just proposing it because it's what we did the last time we had an update like this. |
I see, I would say I understand but I don't know if it's a great idea to keep on changing older versions. For instance, we may break things we now don't test anymore and that were previously working when we tested them. Similar to what we do with RAPIDS, I think it's probably ok to accept the past state of potentially broken libraries. IOW, I think we're fine doing it this once but I'm less convinced we should keep on doing that in the future, open to divergent opinions though. |
I'm inclined to agree with Peter here. After this change I suggest that we stop pushing fixes for older versions than we support in RAPIDS until someone specifically asks for them. |
@trxcllnt if everything looks fine to you here feel free to merge. |
Thanks! @vyasr I can handle repeating this for the other versions:
|
Tested with a So I think we're good to proceed. |
Contributes to rapidsai/build-planning#118 Should only be merged if / after we merge rapidsai/ucx-wheels#13. That PR switches `libucx` wheels' loading behavior, such that `libucx.load_library()` (which `ucx-py` and `libucxx` call at import time) prefers the `libuc{m,p,s}.so` provided by the `libucx` wheels. rapidsai/ucx-wheels#13 introduces an environment variable to control that... this proposes setting that, to continue preferring system-installed UCX libraries in devcontainers. --------- Co-authored-by: Vyas Ramasubramani <[email protected]>
Description
Contributes to rapidsai/build-planning#118
Modifies
libucx.load_library()
in the following ways:RAPIDS_LIBUCX_PREFER_SYSTEM_LIBRARY
for switching that preferenceRTLD_LOCAL
, to prevent adding symbols to the global namespace (dlopen docs)Also updates all the
pre-commit
hook versions while I'm touching this repo. That was harmless, and I especially wanted to get up to the latest version of the RAPIDS copyright hook.Notes for Reviewers
Version changes?
Proposing starting with
1.15.0.post2
because it's the oldest version supported at build and runtime byucxx
(code link).And doing the following, in this order:
ucxx
PR, test with these packages