prefer wheel-provided libucxx.so in load_library, use RTLD_LOCAL #322
Conversation
jameslamb
added
breaking
jameslamb
changed the title
| prefer_system_installation = ( | ||
| os.getenv("RAPIDS_LIBUCXX_PREFER_SYSTEM_LIBRARY", "false").lower() != "false" | ||
| ) |
There was a problem hiding this comment.
Is it intentional to prefer wheel-provided libucxx.so? I thought it was not in the past due to uses with HPC-X containers, are those containers going to set RAPIDS_LIBUCXX_PREFER_SYSTEM_LIBRARY=true by default or is there some other strategy they will follow?
There was a problem hiding this comment.
Sorry, I'm gonna need some context on what "uses with HPC-X containers" is, I'm not familiar with that. Can you describe (here or offline) what that is and how libucxx.so is getting installed and expected to be found there?
There was a problem hiding this comment.
As per discussion offline, this won't affect containers using HPC-X as they do not contain UCXX, so it should be good as is.
python/libucxx/libucxx/load.py
Outdated
| if prefer_system_installation: | ||
| # Prefer a system library if one is present to | ||
| # avoid clobbering symbols that other packages might expect, but if no | ||
| # other library is present use the one in the wheel. | ||
| try: | ||
| libucxx_lib = _load_system_installation(soname) | ||
| except OSError: | ||
| libucxx_lib = _load_wheel_installation(soname) | ||
| else: | ||
| # Prefer the libraries bundled in this package. If they aren't found | ||
| # (which might be the case in builds where the library was prebuilt | ||
| # before packaging the wheel), look for a system installation. | ||
| libucxx_lib = _load_wheel_installation(soname) | ||
| if libucxx_lib is None: | ||
| libucxx_lib = _load_system_installation(soname) | ||
|
|
||
| # The caller almost never needs to do anything with this library, but no | ||
| # harm in offering the option since this object at least provides a handle | ||
| # to inspect where libucxx was loaded from. | ||
| # to inspect where the libucxx was loaded from. | ||
| return libucxx_lib |
There was a problem hiding this comment.
Note that this logic breaks the case of editable installs for developers in (for example) the devcontainer setup.
In that scenario, we don't have a wheel-provided DSO, and we don't have a "system" provided one. Instead, the cython files in the ucxx package have the rpath to the locally built DSO baked in, so ld.so happily finds it. However, here, since we're just asking ld.so to resolve a DSO name, we fail.
There was a problem hiding this comment.
Thanks, just pushed a commit with the changes we discussed offline and seen in rapidsai/kvikio#553. That should address that.
|
/merge |
Description
Contributes to rapidsai/build-planning#118
Modifies
libucxx.load_library()in the following ways:libucxx.soto system installationRAPIDS_LIBUCXX_PREFER_SYSTEM_LIBRARYfor switching that preferencelibucxx.sowithRTLD_LOCAL, to prevent adding symbols to the global namespace (dlopen docs)