Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

replace optparse with argparser #61

Merged

Conversation

chuangz0
Copy link
Contributor

replace optparse with argparser in pylibwholegraph

@chuangz0 chuangz0 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 29, 2023
Copy link
Contributor

@dongxuy04 dongxuy04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@BradReesWork BradReesWork changed the base branch from branch-23.10 to branch-23.12 November 17, 2023 14:20
@BradReesWork BradReesWork added this to the 23.12 milestone Nov 17, 2023
@BradReesWork
Copy link
Member

seems like it would have been easier to left the argument variable named "options" whether than switching to using "args". But "args" is a standard for using argparser

@chuangz0 chuangz0 force-pushed the replace-OptionParser-with-argparse branch 2 times, most recently from 056a310 to c418b0d Compare November 19, 2023 15:41
@BradReesWork
Copy link
Member

/rerun tests

@chuangz0 chuangz0 force-pushed the replace-OptionParser-with-argparse branch from c418b0d to 1a042aa Compare November 21, 2023 15:05
@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 405d86c into rapidsai:branch-23.12 Nov 21, 2023
43 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants