Skip to content

Commit

Permalink
drm/vc4: Remove request for min clocks when hdmi output is disabled
Browse files Browse the repository at this point in the history
Currently, booting with no hdmi connected has:
pi@pi4:~ $ vcgencmd measure_clock hdmi pixel
frequency(9)=120010256
frequency(29)=74988280

After connecting hdmi we get:
pi@pi4:~ $ vcgencmd measure_clock hdmi pixel
frequency(9)=300005856
frequency(29)=149989744

and that persists after disconnecting hdmi

I can measure this on a power supply as [email protected] (52mW).

We should always remove clk_set_min_rate requests
when we no longer need them.

Signed-off-by: Dom Cobley <[email protected]>
  • Loading branch information
popcornmix committed Oct 14, 2024
1 parent 239df14 commit fa099e6
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/gpu/drm/vc4/vc4_hdmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1196,6 +1196,10 @@ static void vc4_hdmi_encoder_post_crtc_disable(struct drm_encoder *encoder,

vc4_hdmi_disable_scrambling(encoder);

/* we not longer have a requirement on minimum clock rates */
clk_set_min_rate(vc4_hdmi->pixel_bvb_clock, 0);
clk_set_min_rate(vc4_hdmi->hsm_clock, 0);

drm_dev_exit(idx);

out:
Expand Down

0 comments on commit fa099e6

Please sign in to comment.