-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCP23017: allow specification of the i2c bus #5650
Conversation
2329c99
to
938957b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good so far. There's one minor in-line comment, but otherwise I'd just like you to add the other i2c buses as well, so that it properly matches i2c-rtc.
@@ -57,13 +57,22 @@ | |||
microchip,irq-mirror; | |||
}; | |||
}; | |||
frag100: fragment@100 { | |||
target = <&i2c_arm>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i2c_arm isn't wrong, but let's keep it as i2c1
anyway for regularity (and because i2c_arm
only exists after the firmware has added it as an alias for i2c1
).
Thank you very much! I've used the wrong branch as template for the i2c block. I've amended the suggested changes analogous to this branch's I2C DTS. |
7f133a3
to
80a43dc
Compare
Analogous to i2c-rtc-overlay.dts
80a43dc
to
50246b9
Compare
Sorry for the multiple amends afterwards; I needed to fix my formatting. I hope it's all good now 🙈 |
kernel: drivers: media: rp1_cfe: Fix link validate test for pixel format See: raspberrypi/linux#5657 kernel: drm/vc4: Correct address offset for planes with src_[xy] offsets See: raspberrypi/linux#5654 kernel: input: touchscreen: edt-ft5x06: Suppress bogus data on startup See: raspberrypi/linux#5645 kernel: vc_mem: Add the DMA memcpy support from bcm2708_fb See: raspberrypi/linux#5651 kernel: dts: bcm2712: Set default I2C baudrates to 100kHz See: raspberrypi/linux#5653 kernel: MCP23017: allow specification of the i2c bus See: raspberrypi/linux#5650 kernel: Revert: bcm2708_fb: Hack out dma support See: raspberrypi/linux#5648 firmware: config: Add [pi5] to config.txt on 2711 and earlier platforms userland: bcm_host: Update kms/fkms check for pi5
kernel: drivers: media: rp1_cfe: Fix link validate test for pixel format See: raspberrypi/linux#5657 kernel: drm/vc4: Correct address offset for planes with src_[xy] offsets See: raspberrypi/linux#5654 kernel: input: touchscreen: edt-ft5x06: Suppress bogus data on startup See: raspberrypi/linux#5645 kernel: vc_mem: Add the DMA memcpy support from bcm2708_fb See: raspberrypi/linux#5651 kernel: dts: bcm2712: Set default I2C baudrates to 100kHz See: raspberrypi/linux#5653 kernel: MCP23017: allow specification of the i2c bus See: raspberrypi/linux#5650 kernel: Revert: bcm2708_fb: Hack out dma support See: raspberrypi/linux#5648 firmware: config: Add [pi5] to config.txt on 2711 and earlier platforms userland: bcm_host: Update kms/fkms check for pi5
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: #5650
Analogous to i2c-rtc-overlay.dts See: raspberrypi/linux#5650
Analogous to i2c-rtc-overlay.dts See: raspberrypi/linux#5650
Analogous to i2c-rtc-overlay.dts See: raspberrypi/linux#5650
commit 2541eaca2c169ca90e017b5a3b014b41c0988909 from https://github.com/raspberrypi/linux.git rpi-6.6.y Analogous to i2c-rtc-overlay.dts See: raspberrypi/linux#5650 Signed-off-by: Rajeshkumar Ramasamy <[email protected]>
commit 2541eaca2c169ca90e017b5a3b014b41c0988909 from https://github.com/raspberrypi/linux.git rpi-6.6.y Analogous to i2c-rtc-overlay.dts See: raspberrypi/linux#5650 Signed-off-by: Rajeshkumar Ramasamy <[email protected]>
commit 2541eaca2c169ca90e017b5a3b014b41c0988909 from https://github.com/raspberrypi/linux.git rpi-6.6.y Analogous to i2c-rtc-overlay.dts See: raspberrypi/linux#5650 Signed-off-by: Rajeshkumar Ramasamy <[email protected]>
commit 2541eaca2c169ca90e017b5a3b014b41c0988909 from https://github.com/raspberrypi/linux.git rpi-6.6.y Analogous to i2c-rtc-overlay.dts See: raspberrypi/linux#5650 Signed-off-by: Rajeshkumar Ramasamy <[email protected]>
commit 2541eaca2c169ca90e017b5a3b014b41c0988909 from https://github.com/raspberrypi/linux.git rpi-6.6.y Analogous to i2c-rtc-overlay.dts See: raspberrypi/linux#5650 Signed-off-by: Rajeshkumar Ramasamy <[email protected]>
commit 2541eaca2c169ca90e017b5a3b014b41c0988909 from https://github.com/raspberrypi/linux.git rpi-6.6.y Analogous to i2c-rtc-overlay.dts See: raspberrypi/linux#5650 Signed-off-by: Rajeshkumar Ramasamy <[email protected]>
commit 2541eaca2c169ca90e017b5a3b014b41c0988909 from https://github.com/raspberrypi/linux.git rpi-6.6.y Analogous to i2c-rtc-overlay.dts See: raspberrypi/linux#5650 Signed-off-by: Rajeshkumar Ramasamy <[email protected]>
Analogous to
i2c-rtc-overlay.dts