drm/vc4: Correct address offset for planes with src_[xy] offsets #5654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11cf37e switched to using drm_fb_dma_get_gem_addr instead of drm_fb_dma_get_gem_obj and adding fb->offset[]. However the tiled formats need to compute the offset in a more involved manner than drm_fb_dma_get_gem_addr applies, and we were ending up with the offset for src_[xy] being applied twice. Switch back to using drm_fb_dma_get_gem_obj and fully computing the offsets ourselves. Fixes: 11cf37e ("drm/vc4: Move the buffer offset out of the vc4_plane_state") Signed-off-by: Dave Stevenson <[email protected]>
|
Tested with dual monitor and X. Without the PR I see same desktop on both screens. With the PR I see separate desktops. LGTM |
|
AFAIK Kodi doesn't use source rectangles (only destination rects for letterboxing), so wouldn't be affected anyway. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Oct 17, 2023
kernel: drivers: media: rp1_cfe: Fix link validate test for pixel format See: raspberrypi/linux#5657 kernel: drm/vc4: Correct address offset for planes with src_[xy] offsets See: raspberrypi/linux#5654 kernel: input: touchscreen: edt-ft5x06: Suppress bogus data on startup See: raspberrypi/linux#5645 kernel: vc_mem: Add the DMA memcpy support from bcm2708_fb See: raspberrypi/linux#5651 kernel: dts: bcm2712: Set default I2C baudrates to 100kHz See: raspberrypi/linux#5653 kernel: MCP23017: allow specification of the i2c bus See: raspberrypi/linux#5650 kernel: Revert: bcm2708_fb: Hack out dma support See: raspberrypi/linux#5648 firmware: config: Add [pi5] to config.txt on 2711 and earlier platforms userland: bcm_host: Update kms/fkms check for pi5
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Oct 17, 2023
kernel: drivers: media: rp1_cfe: Fix link validate test for pixel format See: raspberrypi/linux#5657 kernel: drm/vc4: Correct address offset for planes with src_[xy] offsets See: raspberrypi/linux#5654 kernel: input: touchscreen: edt-ft5x06: Suppress bogus data on startup See: raspberrypi/linux#5645 kernel: vc_mem: Add the DMA memcpy support from bcm2708_fb See: raspberrypi/linux#5651 kernel: dts: bcm2712: Set default I2C baudrates to 100kHz See: raspberrypi/linux#5653 kernel: MCP23017: allow specification of the i2c bus See: raspberrypi/linux#5650 kernel: Revert: bcm2708_fb: Hack out dma support See: raspberrypi/linux#5648 firmware: config: Add [pi5] to config.txt on 2711 and earlier platforms userland: bcm_host: Update kms/fkms check for pi5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
11cf37e switched to using drm_fb_dma_get_gem_addr instead of drm_fb_dma_get_gem_obj and adding fb->offset[].
However the tiled formats need to compute the offset in a more involved manner than drm_fb_dma_get_gem_addr applies, and we were ending up with the offset for src_[xy] being applied twice.
Switch back to using drm_fb_dma_get_gem_obj and fully computing the offsets ourselves.
Fixes: 11cf37e ("drm/vc4: Move the buffer offset out of the vc4_plane_state")