drivers: media: imx477: Disable the scaler #5672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The horizontal scaler was enabled for the 2028x1520 and 2028x1080 modes, with a scale factor of 1. It caused a single column of bad pixels on the right edge of the image. Since scaling is not needed for these modes, disable it entirely. Signed-off-by: Naushir Patuck <[email protected]>
|
I'm convinced. Bit weird how we never noticed...! |
|
I think it's partially to do with these being video modes and we don't pixel peek at them often. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Oct 24, 2023
See: raspberrypi/linux#5669 kernel: drivers: media: imx477: Disable the scaler See: raspberrypi/linux#5672 kernel: dt: Add drm_fbN_vc4 overrides for Pi0-4 See: raspberrypi/linux#5675 kernel: fixup! overlays: mcp23017: allow specification of the i2c bus See: raspberrypi/linux#5678 kernel: dts: bcm2712: Add the krnbt parameter
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Oct 24, 2023
See: raspberrypi/linux#5669 kernel: drivers: media: imx477: Disable the scaler See: raspberrypi/linux#5672 kernel: dt: Add drm_fbN_vc4 overrides for Pi0-4 See: raspberrypi/linux#5675 kernel: fixup! overlays: mcp23017: allow specification of the i2c bus See: raspberrypi/linux#5678 kernel: dts: bcm2712: Add the krnbt parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The horizontal scaler was enabled for the 2028x1520 and 2028x1080 modes, with a scale factor of 1. It caused a single column of bad pixels on the right edge of the image. Since scaling is not needed for these modes, disable it entirely.