drivers: media: cfe: Set the CSI-2 link frequency correctly #5691
Conversation
|
LGTM |
|
This is only checking the adjacent node for a link frequency control. If the adjacent node is a mux or bridge, then it may not have a link frequency. I'm just comparing to qcom camss which follows the full chain until it finds a MEDIA_ENT_F_CAM_SENSOR, but actually even that isn't perfect as a parallel to CSI2 bridge, or FPD-LinkIII bridge would mangle the link frequency required. I think the ideal is to follow the chain until you find a node which has a LINK_FREQUENCY control and use that. Both adjacent and end have issues. |
Hmmm, more annoyances. Hopefully the new rev does this right...? |
naushir
force-pushed
the
cfe_link_freq
branch
from
5603775
to
219de44
Compare
naushir
force-pushed
the
cfe_link_freq
branch
from
219de44
to
463d30c
Compare
Use the sensor provided link frequency to set the DPHY timing parameters on stream_on. This replaces the hard-coded 999 MHz value currently being used. As a fallback, revert to the original 999 Mhz link frequency. As a drive-by, fix a 80-character line formatting error. Signed-off-by: Naushir Patuck <[email protected]>
naushir
force-pushed
the
cfe_link_freq
branch
from
463d30c
to
fd7dd93
Compare
|
I think this now looks to be the correct behavior for those pesky bridge/link entities! |
|
If no objections, I'll merge this in later today. |
kernel: fixup! arch/arm64: Add Revision, Serial, Model to cpuinfo See: raspberrypi/linux#5690 kernel: Remove the Zero 2 W DT-based WLAN firmware selection See: raspberrypi/linux#5499 kernel: drivers: media: cfe: Set the CSI-2 link frequency correctly See: raspberrypi/linux#5691 kernel: dts: bcm2712-rpi-5-b: Create some dummy nodes See: raspberrypi/linux#5693
kernel: fixup! arch/arm64: Add Revision, Serial, Model to cpuinfo See: raspberrypi/linux#5690 kernel: Remove the Zero 2 W DT-based WLAN firmware selection See: raspberrypi/linux#5499 kernel: drivers: media: cfe: Set the CSI-2 link frequency correctly See: raspberrypi/linux#5691 kernel: dts: bcm2712-rpi-5-b: Create some dummy nodes See: raspberrypi/linux#5693
Use the sensor provided link frequency to set the DPHY timing parameters on stream_on. This replaces the hard-coded 999 MHz value currently being used. As a fallback, revert to the original 999 Mhz link frequency.
As a drive-by, fix a 80-character line formatting error.