HID: usbhid: Insert USB bus/device ID into HID name #6356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libinput/wlroots/Wayfire/labwc match input device by the device name only. If you add 2 identical USB connected touch devices, you can't select between them. Add the usb bus&device name to the start of the name so that the names end up being unique, Signed-off-by: Dave Stevenson <[email protected]>
pelwell
reviewed
Sep 12, 2024
|
|
||
| if (dev->product) { | ||
| if (dev->manufacturer) | ||
| strlcat(hid->name, " ", sizeof(hid->name)); | ||
| strlcat(hid->name, dev->product, sizeof(hid->name)); | ||
| } | ||
|
|
||
| if (!strlen(hid->name)) | ||
| snprintf(hid->name, sizeof(hid->name), "HID %04x:%04x", | ||
| if (strlen(hid->name) == strlen(dev_name(&dev->dev))) |
There was a problem hiding this comment.
Given the snprintf above, and the fact that other changes just append, how can this condition ever be true?
There was a problem hiding this comment.
It can't.
Too many revisions switching from strscpy to snprintf (to add the usb- prefix), and missing updating this condition.
Ideally this issue wants to be sorted further up the stack (xinput was always happy with multiple identical devices, although you had to reference them by id number rather than name), so I'll have a word with Simon and David T later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as this isn't ideal - it renames all mouse and keyboard devices, as well as touch ones.
libinput/wlroots/Wayfire/labwc match input device by the device name only. If you add 2 identical USB connected touch devices, you can't select between them.
Add the usb bus&device name to the start of the name so that the names end up being unique,
https://forums.raspberrypi.com/viewtopic.php?t=376569