Fix speaker disabling issue after closing microphone app #6383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alitekin-saha
force-pushed
the
rpi-6.6.y
branch
from
be7f65d
to
5b24831
Compare
|
From the looks of it, the problem would occur if both playback and record streams are active - stopping the record stream would mute the playback stream. An explanation along those lines needs to go in the commit message, along with your "Signed-off-by:" line. |
alitekin-saha
force-pushed
the
rpi-6.6.y
branch
from
5b24831
to
13b9f10
Compare
|
Hint: We don't (always?) receive notifications for pushes, so it's always wise to leave a comment to say if you've pushed a change that requires attention. |
Resolves improper handling of the SDMODE pin, which caused issues when the microphone and speaker were used simultaneously. The playback stream check is now correctly based on `substream->stream == SNDRV_PCM_STREAM_PLAYBACK`, ensuring proper control of the audio amplifier. Signed-off-by: Ali Tekin <[email protected]>
alitekin-saha
force-pushed
the
rpi-6.6.y
branch
from
13b9f10
to
1f9f492
Compare
Thanks for the reminder, I've added more lines to the comment. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Sep 26, 2024
See: raspberrypi/linux#6368 kernel: tty/serial: pl011: Also unregister pl011_axi_platform_driver See: raspberrypi/linux#6380 kernel: overlays: wm8960-soundcard: Fix clock declaration See: raspberrypi/linux#6387 kernel: Fix speaker disabling issue after closing microphone app See: raspberrypi/linux#6383 kernel: ASoC: bcm2835-i2s: Set the PERIOD_BYTES min to 256 See: raspberrypi/linux#6386 kernel: drivers: media: imx500: Simplify the vblank control init See: raspberrypi/linux#6388
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Sep 26, 2024
See: raspberrypi/linux#6368 kernel: tty/serial: pl011: Also unregister pl011_axi_platform_driver See: raspberrypi/linux#6380 kernel: overlays: wm8960-soundcard: Fix clock declaration See: raspberrypi/linux#6387 kernel: Fix speaker disabling issue after closing microphone app See: raspberrypi/linux#6383 kernel: ASoC: bcm2835-i2s: Set the PERIOD_BYTES min to 256 See: raspberrypi/linux#6386 kernel: drivers: media: imx500: Simplify the vblank control init See: raspberrypi/linux#6388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue in the Raspberry Pi Voice HAT driver where the speaker is disabled after the microphone app is closed. The root cause of the issue was incorrect handling of the SDMODE pin, which led to unintended behavior when both the microphone and speaker were used together.