devices: imx708: Add a new IMX708 helper class #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naushir
force-pushed
the
next
branch
4 times, most recently
from
a1598a6
to
e94547c
Compare
|
Thanks, Naush. Just a couple of general observations... firstly, we should fix the flake8 complaints, and secondly, could we maybe add some kind of a test for this? We could even make it an example - "here's how you handle an imx708". |
Add a reset() method to the CameraManager class. This will reset the camera manager singleton and in particular cause the sensor modes to be enumerated again within libcamera. Signed-off-by: Naushir Patuck <[email protected]>
naushir
force-pushed
the
next
branch
3 times, most recently
from
563d07a
to
a46184e
Compare
This class provides a convenient helper function set enable/disable sensor HDR mode without relying on external tools. Usage example: ----- from picamera2.devices.imx708 import IMX708 from picamera2 import Picamera2 camera_num = 0 c = IMX708(camera_num) c.set_sensor_hdr_mode(True) picam2 = Picamera2(camera_num) ----- Note that after calling IMX708.set_hdr_mode(), you must re-initialise the Picamera2 instance. Signed-off-by: Naushir Patuck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class provides a convenient helper function set enable/disable sensor HDR mode without relying on external tools. Usage example:
Note that after calling IMX708.set_hdr_mode(), you must re-initialise the Picamera2 instance.
A change to the CameraManager class is also needed to allow it to be reset as it caches sensor modes internally in libcamera.