BTstack prepare for packet logs #425
Conversation
|
I'll switch this to develop if you don't mind. |
|
Sorry, both should have been for 'develop' |
mringwal
changed the title
|
We do some of this in the sdk https://github.com/raspberrypi/pico-sdk/blob/master/src/rp2_common/pico_cyw43_driver/btstack_cyw43.c#L54 where we also check ENABLE_SEGGER_RTT. Maybe we should call hci_dump_enable_packet_log in there as well? |
|
I see. In this case, we can close this PR. The point is, how would people (incl. me) find this? |
|
Maybe I should add a README for the bluetooth examples? The macro is commented out here https://github.com/raspberrypi/pico-examples/blob/master/pico_w/bt/CMakeLists.txt#L53 |
|
A README would be great! |
|
Is this any good? #427 |
pico_w/bt/picow_bt_example_common.c
Outdated
| @@ -87,6 +89,12 @@ int picow_bt_example_init(void) { | |||
| void picow_bt_example_main(void) { | |||
|
|
|||
| btstack_main(0, NULL); | |||
|
|
|||
| // if EANBLE_HCI_DUMP is defined, enable debug output as well as packet logger | |||
| #if ENABLE_HCI_DUMP | |||
There was a problem hiding this comment.
This should be an #ifdef ENABLE_HCI_DUMP with a corresponding #define ENABLE_HCI_DUMP , or an #if WANT_HCI_DUMP.
There was a problem hiding this comment.
Good point. Following the readme here 3ed9698 I've used `#if WANT_HCI_DUMP' in the PR.
Any progress with the readme? :)
There was a problem hiding this comment.
It's waiting for a review.
mringwal
force-pushed
the
btstack-prepare-for-packet-logs
branch
from
697a29b
to
27525a3
Compare
When users have problems, the most efficient way is to analyze the packet logs. This PR makes it easier to enable the packet logger.