-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alby): add connect via settings #632 #640
Conversation
Thank you 👍 Still on holiday for a week, will look into it in more detail afterwards. Some suggestions: You could add them as app in the app selection and instead of "open" use "connect". If window.alby is not available, you could show an install button which opens the Firefox / chrome page. |
6906bff
to
5022d1e
Compare
Done that now, have a look.
Tried that, doesn't match the current app pattern really because Alby is not an app you "install" on your raspiblitz.
Did that now by copying the two main components. |
Thanks, Hannes, for tackling this issue.
|
According to the Alby source the commando-adapter needs:
You know how the data from this "Core Lightning" example do match these?:
In the connector info it says "Create a rune by running 'lightning-cli commando-rune'." Should this be done by raspiblitz and added to the API data? Or am I missing something? I adjusted the copy-text. Any preferences what to use for the three images in the detail section? |
7333fb5
to
54a3314
Compare
Instead of the second Button which displays the info, I think we could just remove the screenshots and just display one button (the info button, which opens the alby page / connect button if alby installed). |
9cd012f
to
b6dd039
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the change!
Only some small comments. Tested it out, worked great :)
@MoritzKa Just to make sure: It's fine if we use the Alby logo for the WebUI right? :) |
@escapedcat Alby also got a SVG of their logo, maybe we could use that: https://github.com/getAlby/media/blob/main/alby-sticker.svg Doesn't have a white background and would maybe fit better. |
Was using the png because all others boxes use pngs and Updated it to a transparent png. |
@escapedcat approved, thank you very much 👍 |
Resolves #632
Third Iteration
Current state
Second Iteration (outdated)
Alby installed
Alby not installed
Open points
First Iteration (outdated)
First iteration.
Decided to go for settings because adding the account to the Alby extension doesn't feel like "Installing an App".
Open for suggestions though. At least this should work.
Could continue to iterate i.e.